From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org, Markus Heidelberg <markus.heidelberg@web.de>,
Sverre Rabbelier <srabbelier@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/3] bash completion: refactor --strategy completion
Date: Fri, 6 Mar 2009 08:32:33 -0800 [thread overview]
Message-ID: <20090306163233.GL16213@spearce.org> (raw)
In-Reply-To: <1236357044-55479-1-git-send-email-jaysoffian@gmail.com>
Jay Soffian <jaysoffian@gmail.com> wrote:
> The code to complete --strategy was duplicated between _git_rebase and
> _git_merge, and is about to gain a third caller (_git_pull). This patch
> factors it into its own function.
>
> Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
> ---
> How about like this intead? This way 3/3 doesn't need to be adjusted. The
> interdiff is:
Yup, that works too!
Acked-by: Shawn O. Pearce <spearce@spearce.org>
> contrib/completion/git-completion.bash | 38 ++++++++++++++++---------------
> 1 files changed, 20 insertions(+), 18 deletions(-)
--
Shawn.
next prev parent reply other threads:[~2009-03-06 16:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 4:39 [PATCH 0/3] improve bash completion of fetch, pull, and push Jay Soffian
2009-03-06 4:39 ` [PATCH 1/3] bash completion: fix completion issues with " Jay Soffian
2009-03-06 15:58 ` Shawn O. Pearce
2009-03-11 10:02 ` Nanako Shiraishi
2009-03-11 14:57 ` Jay Soffian
2009-03-06 4:39 ` [PATCH 2/3] bash completion: refactor --strategy completion Jay Soffian
2009-03-06 16:04 ` Shawn O. Pearce
2009-03-06 16:12 ` Jay Soffian
2009-03-06 16:16 ` Shawn O. Pearce
2009-03-06 16:30 ` Jay Soffian
2009-03-06 16:32 ` Shawn O. Pearce [this message]
2009-03-06 4:39 ` [PATCH 3/3] bash completion: teach fetch, pull, and push to complete their options Jay Soffian
2009-03-06 16:15 ` Shawn O. Pearce
2009-03-06 6:43 ` [PATCH 0/3] improve bash completion of fetch, pull, and push Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090306163233.GL16213@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
--cc=markus.heidelberg@web.de \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.