All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 4/5 v3] tracing/core: drop the old ftrace_printk implementation in favour of ftrace_bprintk
Date: Fri, 6 Mar 2009 18:14:05 +0100	[thread overview]
Message-ID: <20090306171403.GA7329@nowhere> (raw)
In-Reply-To: <alpine.DEB.2.00.0903061146000.23248@gandalf.stny.rr.com>

On Fri, Mar 06, 2009 at 11:49:40AM -0500, Steven Rostedt wrote:
> 
> 
> On Fri, 6 Mar 2009, Frederic Weisbecker wrote:
> 
> > Impact: faster and lighter tracing
> > 
> > Now that we have ftrace_bprintk() which is faster and consume lesser
> > memory than ftrace_printk() and has the same purpose, we can now drop
> > the old implementation in favour of the binary one from ftrace_bprintk(),
> > which means we move all the implementation of ftrace_bprintk() to
> > ftrace_printk(), so the Api doesn't change except that we must now use
> > trace_seq_bprintk() to print the TRACE_PRINT entries.
> > 
> > Some changes result of this:
> > 
> > - Previously, ftrace_bprintk depended of a single tracer and couldn't
> >   work without. This tracer has been dropped and the whole implementation
> >   of ftrace_printk() (like the module formats management) is now integrated
> >   in the tracing core (comes with CONFIG_TRACING), though we keep the file
> >   trace_printk (previously trace_bprintk.c) where we can find the module
> >   management. Thus we don't overflow trace.c
> > 
> > - changes some parts to use trace_seq_bprintk() to print TRACE_PRINT entries.
> > 
> > - change a bit ftrace_printk/ftrace_vprintk macros to support non-builtin formats
> >   constants, and fix 'const' qualifiers warnings. But this is all transparent for
> >   developers.
> > 
> > - etc...
> > 
> > V2:
> > 
> > - Rebase against last changes
> > - Fix mispell on the changelog
> > 
> > V3:
> > 
> > - Rebase against last changes (moving ftrace_printk() to kernel.h)
> > 
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> 
> Very nice Frederic!


Thanks!

 
> For some reason I'm still missing patch 1. Perhaps it decided to take the
> scenic route ;-)
> 
> > diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> > index 0f5077f..6140922 100644
> > --- a/kernel/trace/trace.h
> > +++ b/kernel/trace/trace.h
> > @@ -20,7 +20,6 @@ enum trace_type {
> >  	TRACE_WAKE,
> >  	TRACE_STACK,
> >  	TRACE_PRINT,
> > -	TRACE_BPRINTK,
> >  	TRACE_SPECIAL,
> >  	TRACE_MMIO_RW,
> >  	TRACE_MMIO_MAP,
> > @@ -120,16 +119,10 @@ struct userstack_entry {
> >   */
> >  struct print_entry {
> >  	struct trace_entry	ent;
> > -	unsigned long		ip;
> > +	unsigned long 		ip;
> >  	int			depth;
> > -	char			buf[];
> > -};
> > -
> 
> 
> Note, this is going to break my recent patch that exports the internal 
> ftrace events.

Argh, sorry I forgot these recent patches.

> That's OK, I'll fix it after Ingo pulls it in.


Thanks :-)


> Ingo,
> 
> Would you prefer that I pull these patches in and then fix the code, and 
> let you pull it from me?
> 
> -- Steve
> 


  parent reply	other threads:[~2009-03-06 17:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06 16:21 [PATCH 0/5 v3] Binary ftrace_printk Frederic Weisbecker
2009-03-06 16:21 ` [PATCH 1/5 v2] add binary printf Frederic Weisbecker
2009-03-06 16:50   ` Steven Rostedt
2009-03-06 17:00   ` [tip:core/printk] vsprintf: " Lai Jiangshan
2009-03-06 16:21 ` [PATCH 2/5 v3] ftrace: infrastructure for supporting binary record Frederic Weisbecker
2009-03-06 17:00   ` [tip:tracing/printk] tracing: " Lai Jiangshan
2009-03-06 16:21 ` [PATCH 3/5 v3] ftrace: add ftrace_bprintk() Frederic Weisbecker
2009-03-06 17:00   ` [tip:tracing/printk] tracing: add trace_bprintk() Lai Jiangshan
2009-03-06 16:21 ` [PATCH 4/5 v3] tracing/core: drop the old ftrace_printk implementation in favour of ftrace_bprintk Frederic Weisbecker
2009-03-06 16:49   ` Steven Rostedt
2009-03-06 17:02     ` Ingo Molnar
2009-03-06 17:14       ` Ingo Molnar
2009-03-06 18:04         ` Steven Rostedt
2009-03-06 18:49           ` Ingo Molnar
2009-03-06 19:09             ` Frederic Weisbecker
2009-03-06 19:17             ` Ingo Molnar
2009-03-06 17:14     ` Frederic Weisbecker [this message]
2009-03-06 17:01   ` [tip:tracing/printk] tracing/core: drop the old trace_printk() implementation in favour of trace_bprintk() Frederic Weisbecker
2009-03-06 17:01   ` [tip:tracing/printk] tracing: trace_bprintk() cleanups Ingo Molnar
2009-03-09  9:12   ` [tip:tracing/printk] tracing: trace_printk() fix, move format array to data section Ingo Molnar
2009-03-09  9:12   ` [tip:tracing/printk] tracing: optimize trace_printk() Ingo Molnar
2009-03-09 17:23     ` Steven Rostedt
2009-03-09 17:24       ` Steven Rostedt
2009-03-09 17:38         ` Frederic Weisbecker
2009-03-06 16:21 ` [PATCH 5/5 v3] vsprintf: unify the format decoding layer for its 3 users Frederic Weisbecker
2009-03-06 17:00   ` [tip:core/printk] " Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090306171403.GA7329@nowhere \
    --to=fweisbec@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.