From: Arjan van de Ven <arjan@infradead.org>
To: Tilman Schmidt <tilman@imap.cc>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Paul Bolle <pebolle@tiscali.nl>,
Hansjoerg Lipp <hjlipp@web.de>
Subject: Re: [PATCH 1/2] gigaset: return -ENOSYS for unimplemented functions
Date: Sat, 7 Mar 2009 14:26:09 -0800 [thread overview]
Message-ID: <20090307142609.2995bb3d@infradead.org> (raw)
In-Reply-To: <20090307-patch-01.tilman@imap.cc>
On Sat, 7 Mar 2009 23:10:57 +0100 (CET)
Tilman Schmidt <tilman@imap.cc> wrote:
> From: Paul Bolle <pebolle@tiscali.nl>
>
> A number of functions in the usb_gigaset module will return -EINVAL if
> CONFIG_GIGASET_UNDOCREQ is not set. Make these return -ENOSYS as it's
> more specific and it might make it easier to see (from userspace) why
> these functions actually fail.
>
> Impact: some error return codes changed
ENODEV is what would be more appropriate.
ENOSYS shuoldn't be returned from drivers, only from unimplemented
system calls!
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2009-03-07 22:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-07 22:10 [PATCH 0/2] gigaset: patches for 2.6.30 Tilman Schmidt
2009-03-07 22:10 ` [PATCH 1/2] gigaset: return -ENOSYS for unimplemented functions Tilman Schmidt
2009-03-07 22:26 ` Arjan van de Ven [this message]
2009-03-08 0:22 ` Tilman Schmidt
2009-03-08 0:35 ` Arjan van de Ven
2009-03-08 0:55 ` Tilman Schmidt
2009-03-08 1:38 ` Arjan van de Ven
2009-03-08 12:26 ` Tilman Schmidt
2009-03-08 15:23 ` [PATCH 1/2 v2] gigaset: return -ENOTTY " Tilman Schmidt
2009-03-10 12:25 ` David Miller
2009-03-07 22:11 ` [PATCH 2/2] gigaset: Kconfig cleanup Tilman Schmidt
2009-03-10 12:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090307142609.2995bb3d@infradead.org \
--to=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=hjlipp@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.