From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Lfybc-0007gm-FP for mharc-grub-devel@gnu.org; Sat, 07 Mar 2009 10:38:28 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lfyba-0007f1-LG for grub-devel@gnu.org; Sat, 07 Mar 2009 10:38:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LfybZ-0007e1-0g for grub-devel@gnu.org; Sat, 07 Mar 2009 10:38:26 -0500 Received: from [199.232.76.173] (port=40757 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfybY-0007dy-Rk for grub-devel@gnu.org; Sat, 07 Mar 2009 10:38:24 -0500 Received: from aybabtu.com ([69.60.117.155]:35310) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LfybY-0000yJ-8P for grub-devel@gnu.org; Sat, 07 Mar 2009 10:38:24 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LfyTe-0005cs-0e for grub-devel@gnu.org; Sat, 07 Mar 2009 16:30:16 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LfybP-0003xu-Dt for grub-devel@gnu.org; Sat, 07 Mar 2009 16:38:15 +0100 Date: Sat, 7 Mar 2009 16:38:15 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090307153815.GA15220@thorin> References: <49B28BA6.3030109@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49B28BA6.3030109@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [Design] nested partitions: Unify grub_partition and grub_disk X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Mar 2009 15:38:26 -0000 On Sat, Mar 07, 2009 at 03:58:46PM +0100, phcoder wrote: > Hello. I was looking into nested partitions issue and propose to unify > grub_partition and grub_disk. In this case when a code calls > grub_disk_read with a grub_disk_t which represents a partition it will > correct the offset and call grub_disk_read with underlying partition or > disk. In this way not only nested partitions become natural but also > conceptually similar fields of total_sectors and len become unified. As > it's an important design change I send this e-mail before coding it Makes sense to me. But it'd be interesting to hear from the person who designed it this way. Perhaps there's a non-obvious reason. Who's that? Maybe Marco or Okuji? Also an interesting question is how would "has_partitions" field be handled in this scheme. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."