All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	hal@lists.freedesktop.org, Richard Hughes <hughsient@gmail.com>
Subject: Re: [PATCH] toshiba_acpi: Add full hotkey support
Date: Sat, 7 Mar 2009 15:44:24 +0000	[thread overview]
Message-ID: <20090307154424.GA3909@srcf.ucam.org> (raw)
In-Reply-To: <200903071839.16508.arvidjaar@mail.ru>

On Sat, Mar 07, 2009 at 06:38:53PM +0300, Andrey Borzenkov wrote:

> - patch toshiba_acpi to return KEY_SUSPEND/KEY_HIBERNATE instead of 
> KEY_SLEEP/KEY_SUSPEND. This depends on commit 
> 6932b918e05b06165ed3457a9f3aa279099a7cbd in linux-next.
> 
> - patch HAL to recognize KEY_HIBERNATE and return "suspend" for 
> KEY_SUSPEND; right now it is:
> 
>         [KEY_SLEEP] = "sleep",
>         [KEY_SUSPEND] = "hibernate",

Ugh. Why are we changing this? The semantics were pretty clear before. 
The KEY_SUSPEND to hibernate mapping was decided years ago, and it's 
clearly an incompatible change as far as userspace goes.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2009-03-07 15:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06  0:39 [PATCH] toshiba_acpi: Add full hotkey support Matthew Garrett
2009-03-06  0:52 ` Matthew Garrett
2009-03-06  9:08   ` Richard Hughes
2009-03-06  9:47     ` Daniel Silverstone
2009-03-06  9:56       ` Matthew Garrett
2009-03-06 10:04         ` Daniel Silverstone
2009-03-06 10:09           ` Matthew Garrett
2009-03-06 10:12             ` Daniel Silverstone
2009-03-06 10:15               ` Matthew Garrett
2009-03-06 10:21                 ` Daniel Silverstone
2009-03-06 18:49                   ` Andrey Borzenkov
2009-03-06 18:53                     ` Matthew Garrett
2009-03-06 18:37   ` Andrey Borzenkov
2009-03-06 18:44     ` Matthew Garrett
2009-03-06 18:57       ` Andrey Borzenkov
2009-03-07  7:27   ` Andrey Borzenkov
2009-03-07 15:06     ` Matthew Garrett
2009-03-07 15:38       ` Andrey Borzenkov
2009-03-07 15:44         ` Matthew Garrett [this message]
2009-03-07 20:19           ` Richard Hughes
2009-03-07 20:19             ` Richard Hughes
2009-03-07 20:26             ` Matthew Garrett
2009-03-07 20:26               ` Matthew Garrett
2009-03-08  8:33               ` Richard Hughes
2009-03-08 14:29                 ` Andrey Borzenkov
2009-03-08 14:36                 ` Matthew Garrett
2009-03-09 17:11                 ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090307154424.GA3909@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=arvidjaar@mail.ru \
    --cc=hal@lists.freedesktop.org \
    --cc=hughsient@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.