From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
hpa@zytor.com, hch@lst.de, sukadev@us.ibm.com,
Containers <containers@lists.osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [v2][PATCH 2/5] Parse mount options just once and copy them to super block
Date: Sat, 7 Mar 2009 09:31:29 -0800 [thread overview]
Message-ID: <20090307173129.GA29293@us.ibm.com> (raw)
In-Reply-To: <20090205001010.GC17354@us.ibm.com>
Sorry, I had not responded to this:
Serge E. Hallyn [serue@us.ibm.com] wrote:
| > - if (new)
| > - return new_pts_mount(fs_type, flags, data, mnt);
| > + memset(&opts, 0, sizeof(opts));
| > + if (data) {
| > + error = parse_mount_options(data, PARSE_MOUNT, &opts);
|
| Is there any reason to keep the PARSE_MOUNT argument to
| parse_mount_options?
Yes parse_mount_options() needs to know whether it is a MOUNT or
REMOUNT operation - MOUNT operation should clear 'newinstance' to
default before parsing, but REMOUNT should not.
next prev parent reply other threads:[~2009-03-07 17:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 4:35 [PATCH 0/5][v2] Simplify devpts code Sukadev Bhattiprolu
2009-02-04 4:36 ` [v2][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts Sukadev Bhattiprolu
[not found] ` <20090204043640.GA26202-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-04 23:49 ` Serge E. Hallyn
2009-02-04 23:49 ` Serge E. Hallyn
2009-02-05 0:27 ` Serge E. Hallyn
2009-02-04 4:37 ` [v2][PATCH 2/5] Parse mount options just once and copy them to super block Sukadev Bhattiprolu
2009-02-05 0:10 ` Serge E. Hallyn
2009-03-07 17:31 ` Sukadev Bhattiprolu [this message]
[not found] ` <20090204043516.GB25963-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-04 4:37 ` [v2][PATCH 3/5] Move common mknod_ptmx() calls into caller Sukadev Bhattiprolu
2009-02-04 4:37 ` Sukadev Bhattiprolu
[not found] ` <20090204043732.GC26202-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-05 0:26 ` Serge E. Hallyn
2009-02-05 0:26 ` Serge E. Hallyn
2009-02-04 4:37 ` [v2][PATCH 4/5] Remove get_init_pts_sb() Sukadev Bhattiprolu
2009-02-04 4:37 ` Sukadev Bhattiprolu
[not found] ` <20090204043752.GD26202-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-05 1:07 ` Serge E. Hallyn
2009-02-05 1:07 ` Serge E. Hallyn
2009-02-04 4:38 ` [v2][PATCH 5/5] Merge code for single and multiple-instance mounts Sukadev Bhattiprolu
2009-02-04 4:38 ` Sukadev Bhattiprolu
2009-02-06 18:51 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090307173129.GA29293@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=containers@lists.osdl.org \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=sukadev@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.