From: Johannes Sixt <j6t@kdbg.org>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Brown paper bag fix for MinGW 64-bit stat
Date: Sat, 7 Mar 2009 20:46:23 +0100 [thread overview]
Message-ID: <200903072046.23965.j6t@kdbg.org> (raw)
In-Reply-To: <03fcab37c921f5728deded11c07bdf32a263b79b.1236436185u.git.johannes.schindelin@gmx.de>
On Samstag, 7. März 2009, Johannes Schindelin wrote:
> Actually, it was quite funny that t4200 displayed the bug; I
> _guess_ it was due to a time zone issue, as the times were exactly
> one hour off (and the machine I tested on is at UTC+0100 right now).
>
> And due to that bug, "rerere gc" would not collect the garbage.
U-oh, you are right! I was 100% sure that I ran the test-suite suite with your
earlier patch and it was all OK before I gave my ACK. But appearently I did
something wrong because today I see the failure in t4200, too, and this fixes
it, and it is the right thing to do.
> -#define stat64(x,y) mingw_lstat(x,y)
> +#define _stati64(x,y) mingw_lstat(x,y)
Acked-by: Johannes Sixt <j6t@kdbg.org>
-- Hannes
next prev parent reply other threads:[~2009-03-07 19:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1236436185u.git.johannes.schindelin@gmx.de>
2009-03-07 14:37 ` [PATCH] Brown paper bag fix for MinGW 64-bit stat Johannes Schindelin
2009-03-07 19:46 ` Johannes Sixt [this message]
2009-03-07 20:00 ` Junio C Hamano
2009-03-07 21:02 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903072046.23965.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.