From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LgId4-0001KB-HI for mharc-grub-devel@gnu.org; Sun, 08 Mar 2009 09:01:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LgId1-0001Jp-Vu for grub-devel@gnu.org; Sun, 08 Mar 2009 09:01:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LgIcz-0001Io-Ol for grub-devel@gnu.org; Sun, 08 Mar 2009 09:01:15 -0400 Received: from [199.232.76.173] (port=47033 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LgIcz-0001Ib-IV for grub-devel@gnu.org; Sun, 08 Mar 2009 09:01:13 -0400 Received: from mx20.gnu.org ([199.232.41.8]:13905) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LgIcy-00020I-Vk for grub-devel@gnu.org; Sun, 08 Mar 2009 09:01:13 -0400 Received: from aybabtu.com ([69.60.117.155]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LgIcu-0004Jh-IQ for grub-devel@gnu.org; Sun, 08 Mar 2009 09:01:08 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LgIUx-0004Kf-FE for grub-devel@gnu.org; Sun, 08 Mar 2009 13:52:55 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LgIcs-0003bS-5A for grub-devel@gnu.org; Sun, 08 Mar 2009 14:01:06 +0100 Date: Sun, 8 Mar 2009 14:01:06 +0100 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20090308130106.GC28707@thorin> References: <20090306195735.GA9992@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090306195735.GA9992@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] linux/gfxterm integration X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Mar 2009 13:01:16 -0000 On Fri, Mar 06, 2009 at 08:57:35PM +0100, Robert Millan wrote: > > This patch integrates the generic Linux loader with gfxterm. The result is > that graphical mode becomes usable with this loader. Our loader gets the > screen settings from the video subsystem (as per gfxterm setup), and passes > them to Linux. > > This way GRUB/gfxterm can transition to Linux/fb with no further mode > setting. Perhaps this can be exploited to make the transition seamless > by using the same background image in both places, but I haven't explored > this possibility yet :-) > > Note: As the comment in grub/video.h says, struct grub_video_render_target > didn't really want to be moved. My code only needs to access it to find > the framebuffer address. Perhaps it'd be better to move this information > elsewhere? Or split it in a separate structure / getter? New patch. This one calls grub_linux_setup_video() from grub_linux32_boot instead of grub_rescue_cmd_linux. This way it gets the video status we have when "boot" is issued instead of the one we have when linux is loaded. Any comments on my question about struct grub_video_render_target ? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."