From: Andre Noll <maan@systemlinux.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "neilb@suse.de" <neilb@suse.de>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"Ciechanowski, Ed" <ed.ciechanowski@intel.com>,
"Danecki, Jacek" <jacek.danecki@intel.com>
Subject: Re: [PATCH 3/3] md: 'array_size' sysfs attribute
Date: Mon, 9 Mar 2009 11:12:29 +0100 [thread overview]
Message-ID: <20090309101229.GI17185@skl-net.de> (raw)
In-Reply-To: <1236407289.28806.9.camel@dwillia2-linux.ch.intel.com>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On 23:28, Dan Williams wrote:
> Subject: md: fixups to the userspace array size changes
>
> From: Dan Williams <dan.j.williams@intel.com>
>
> As identified by Andre Noll <maan@systemlinux.org>:
> 1/ No need to recalculate chunk shift in raid10_size
> 2/ Check for overflow in conversions from blocks to sectors
> 3/ Missing cast to sector_t in raid5_size
>
> Cc: Andre Noll <maan@systemlinux.org>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Yes, these fixes all look fine to me. Feel free to add
Reviewed-by: Andre Noll <maan@systemlinux.org>
Thanks
Andre
--
The only person who always got his work done by Friday was Robinson Crusoe
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2009-03-09 10:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 0:24 [PATCH 0/3] Support setting the array size from userspace Dan Williams
2009-03-06 0:24 ` [PATCH 1/3] md: add 'size' as a personality method Dan Williams
2009-03-06 16:15 ` Andre Noll
2009-03-06 17:55 ` Dan Williams
2009-03-06 0:24 ` [PATCH 2/3] md: centralize ->array_sectors modifications Dan Williams
2009-03-06 0:24 ` [PATCH 3/3] md: 'array_size' sysfs attribute Dan Williams
2009-03-06 16:15 ` Andre Noll
2009-03-06 18:20 ` Dan Williams
2009-03-07 6:28 ` Dan Williams
2009-03-09 10:12 ` Andre Noll [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090309101229.GI17185@skl-net.de \
--to=maan@systemlinux.org \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=jacek.danecki@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.