All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helmut Schaa <helmut.schaa@googlemail.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net
Subject: Re: [PATCH] mac80211: handle failed scan requests in STA mode
Date: Mon, 9 Mar 2009 16:17:07 +0100	[thread overview]
Message-ID: <200903091617.08149.helmut.schaa@gmail.com> (raw)
In-Reply-To: <200903091547.09223.helmut.schaa@gmail.com>

Am Montag, 9. M=E4rz 2009 schrieb Helmut Schaa:
> If cfg80211 requests a scan it awaits either a return code !=3D 0 fro=
m
> the scan function or the cfg80211_scan_done to be called. In case of
> a STA mac80211's scan function ever returns 0 and queues the scan req=
uest.
> If ieee80211_sta_work is executed and ieee80211_start_scan fails for
> some reason cfg80211_scan_done will never be called but cfg80211 stil=
l
> thinks the scan was triggered successfully and will refuse any future
> scan requests due to drv->scan_req not being cleaned up.
>=20
> If a scan is triggered from within the MLME a similar problem appears=
=2E If
> ieee80211_start_scan returns an error, local->scan_req will not be re=
set
> and mac80211 will refuse any future scan requests.
>=20
> Hence, in both cases call ieee80211_scan_failed (which notifies cfg80=
211
> and resets local->scan_req) if ieee80211_start_scan returns an error.
>=20
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>

Btw, John, I guess this should go into linux-next as the cfg80211-scan =
code
is there already and otherwise cfg80211 and mac80211 can get stuck (ref=
uses
any scan requests) when the iwlwifi killswitch is used (only tested wit=
h
NetworkManager).

I'm not sure if anything apart from the killswitch also triggers this i=
ssue.

Thanks,
Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2009-03-09 15:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-09 14:47 [PATCH] mac80211: handle failed scan requests in STA mode Helmut Schaa
2009-03-09 14:50 ` Johannes Berg
2009-03-09 15:03   ` Helmut Schaa
2009-03-09 15:07     ` Johannes Berg
2009-03-09 15:17 ` Helmut Schaa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903091617.08149.helmut.schaa@gmail.com \
    --to=helmut.schaa@googlemail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.