From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 0/7] sensord: Coding style conversion (gnu
Date: Mon, 09 Mar 2009 16:20:24 +0000 [thread overview]
Message-ID: <20090309172024.502ade6b@hyperion.delvare> (raw)
In-Reply-To: <20090309084458.GA4636@ubuntu>
On Mon, 9 Mar 2009 16:49:41 +0100, Andre Prendel wrote:
> On Mon, Mar 09, 2009 at 11:19:45AM +0100, Jean Delvare wrote:
> > Hallo Andre,
>
> Salut Jean,
>
> >
> > On Mon, 9 Mar 2009 09:44:58 +0100, Andre Prendel wrote:
> > > This patch series converts the coding style in prog/sensord/ from gnu to
> > > kernel style. So we are consistent all over the project.
> > >
> > > The conversion have exposed some very deep indentation levels. So it
> > > was impossible to not break the 80-characters-per-line rule. Some of
> > > them I already fixed, but other ones can only be fixed by
> > > restructuring the code. I will do that in further patches.
> > >
> > > --
> > > args.c | 462 +++++++++++++++++++-------------------
> > > chips.c | 547 +++++++++++++++++++++++----------------------
> > > lib.c | 119 +++++----
> > > rrd.c | 743 ++++++++++++++++++++++++++++++++------------------------------
> > > sense.c | 399 +++++++++++++++++----------------
> > > sensord.c | 382 ++++++++++++++++---------------
> > > sensord.h | 61 ++---
> > > 7 files changed, 1395 insertions(+), 1318 deletions(-)
> >
> > No objection from me, feel free to apply all these patches.
>
> Applied with your suggestion to patch 6/7.
Thanks!
> BTW, how do you send patch series? I use quilt to handle the
> patches. The E-Mails I have though written by hand. Maybe I should try
> quilt mail. Have you any experiences with it?
I've always been too chicken and/or psychorigid to try quilt mail. I
always send my patch series manually, sending 0/N first and then all
the actual patches as a reply to 0/N. But that's quite some work and
error prone, so I'm not sure if I can sanely recommend that.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2009-03-09 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 8:44 [lm-sensors] [PATCH 0/7] sensord: Coding style conversion (gnu -> Andre Prendel
2009-03-09 10:19 ` [lm-sensors] [PATCH 0/7] sensord: Coding style conversion (gnu Jean Delvare
2009-03-09 15:49 ` Andre Prendel
2009-03-09 16:20 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090309172024.502ade6b@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.