All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Denemark <jdenemar@redhat.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] Test tap devices in testDeviceComplete()
Date: Tue, 10 Mar 2009 10:19:23 +0100	[thread overview]
Message-ID: <20090310091923.GA6865@orkuz.home> (raw)

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

Hi,

XendDomainInfo.testDeviceComplete() should check block devices have shutdown
correctly but it only considers vbd class devices and ignores tap devices. The
attached patch changes testDeviceComplete() to wait for both vbd and tap
devices to be shutdown correctly.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>

[-- Attachment #2: xend-check-released-tap-devices.patch --]
[-- Type: text/plain, Size: 673 bytes --]

diff -r b249f3e979a5 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py	Mon Mar 09 10:32:24 2009 +0000
+++ b/tools/python/xen/xend/XendDomainInfo.py	Tue Mar 10 09:59:16 2009 +0100
@@ -2888,7 +2888,9 @@
         while True:
             test = 0
             diff = time.time() - start
-            for i in self.getDeviceController('vbd').deviceIDs():
+            vbds = self.getDeviceController('vbd').deviceIDs()
+            taps = self.getDeviceController('tap').deviceIDs()
+            for i in vbds + taps:
                 test = 1
                 log.info("Dev %s still active, looping...", i)
                 time.sleep(0.1)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2009-03-10  9:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-10  9:19 Jiri Denemark [this message]
2009-03-10  9:31 ` [PATCH] Test tap devices in testDeviceComplete() Christoph Egger
2009-03-10  9:57   ` Jiri Denemark
2009-03-10 10:01   ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090310091923.GA6865@orkuz.home \
    --to=jdenemar@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.