From: Ingo Molnar <mingo@elte.hu>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, lethal@linux-sh.org,
tglx@linutronix.de, akpm@linux-foundation.org
Subject: Re: [PATCH] Free setup_irq() interrupt V2
Date: Tue, 10 Mar 2009 13:41:23 +0100 [thread overview]
Message-ID: <20090310124123.GF5794@elte.hu> (raw)
In-Reply-To: <20090310102459.23422.80761.sendpatchset@rx1.opensource.se>
* Magnus Damm <magnus.damm@gmail.com> wrote:
> From: Magnus Damm <damm@igel.co.jp>
>
> This patch adds a __free_irq() function for releasing
> interrupts requested with setup_irq().
>
> Without this patch we have no way of releasing such
> interrupts since free_irq() today tries to kfree()
> the irqaction passed with setup_irq().
>
> Signed-off-by: Magnus Damm <damm@igel.co.jp>
> ---
>
> Changes since V1:
> - break out a __free_irq() function, thanks Ingo!
Looks good. Could you please send it against the latest genirq
tree:
http://people.redhat.com/mingo/tip.git/README
as your patch does not apply cleanly anymore:
1 out of 3 hunks FAILED -- rejects in file kernel/irq/manage.c
> Why again are we not using struct list_head for the irqaction list?
irq_desc size mostly.
Ingo
next prev parent reply other threads:[~2009-03-10 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 10:24 [PATCH] Free setup_irq() interrupt V2 Magnus Damm
2009-03-10 12:41 ` Ingo Molnar [this message]
2009-03-10 14:26 ` Thomas Gleixner
2009-03-10 15:04 ` Ingo Molnar
2009-03-10 15:26 ` Thomas Gleixner
2009-03-10 15:33 ` Ingo Molnar
2009-03-11 2:32 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310124123.GF5794@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.