From: "Daniel P. Berrange" <berrange@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Use of asprintf() breaks build on systems where asprintf() is not available
Date: Wed, 11 Mar 2009 10:48:09 +0000 [thread overview]
Message-ID: <20090311104809.GA23995@redhat.com> (raw)
In-Reply-To: <49B6E2F9.3020803@codemonkey.ws>
On Tue, Mar 10, 2009 at 05:00:25PM -0500, Anthony Liguori wrote:
> Palle Lyckegaard wrote:
> >Hi,
> >
> >A few source-files, e.g. vnc.c, makes use of the (non-portable?)
> >asprintf() function, which is not available in e.g. Solaris 10 and
> >certain builds of OpenSolaris.
> >
> >What would be the proper "qemu" way of solving this problem? Creating
> >a library with the functions not avilable on the host system or
> >replacing the non-portable use(s) of the function(s) with proper
> >portable function(s)?
>
> Can you send in a patch to add the gnulib asprintf() with an appropriate
> configure test?
I think it is just easier to remove the use of asprinf() from vnc.c It is
only used once and not really all that hard to remove.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
next prev parent reply other threads:[~2009-03-11 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 21:38 [Qemu-devel] Use of asprintf() breaks build on systems where asprintf() is not available Palle Lyckegaard
2009-03-10 22:00 ` Anthony Liguori
2009-03-11 10:48 ` Daniel P. Berrange [this message]
2009-03-11 13:52 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090311104809.GA23995@redhat.com \
--to=berrange@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.