From: Felipe Balbi <me@felipebalbi.com>
To: David Brownell <david-b@pacbell.net>
Cc: OMAP <linux-omap@vger.kernel.org>
Subject: Re: [patch 2.6.29-rc7-omap] OMAP1: OMAP_TAG_USB buildfix (OSK)
Date: Wed, 11 Mar 2009 17:28:57 +0200 [thread overview]
Message-ID: <20090311152857.GA19730@gandalf> (raw)
In-Reply-To: <200903110320.06011.david-b@pacbell.net>
On Wed, Mar 11, 2009 at 02:20:05AM -0800, David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Build fix:
>
> CC arch/arm/mach-omap1/board-osk.o
> arch/arm/mach-omap1/board-osk.c: In function 'osk_mistral_init':
> arch/arm/mach-omap1/board-osk.c:512: error: implicit declaration of function 'omap_usb_init'
> make[1]: *** [arch/arm/mach-omap1/board-osk.o] Error 1
>
> The error is twofold. First, USB is on the mainboard, not the Mistral card;
> that's specific to the OSK. Second, header goofage -- hurts all OMAP1 boards.
>
> I'm puzzled by the notion tha the "OMAP1: get rid of OMAP_TAG_USB" patch could
> have been compile-tested.
it actually was for all omap1 defconfigs. Weird that these came only now
:-(
--
balbi
next prev parent reply other threads:[~2009-03-11 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 10:20 [patch 2.6.29-rc7-omap] OMAP1: OMAP_TAG_USB buildfix (OSK) David Brownell
2009-03-11 15:28 ` Felipe Balbi [this message]
2009-03-11 16:19 ` Tony Lindgren
2009-03-11 16:32 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090311152857.GA19730@gandalf \
--to=me@felipebalbi.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.