Re: [PATCH] ide: add support for CFA specified transfer modes (take 3)

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Tuesday 10 March 2009, Sergei Shtylyov wrote:
> Add support for the CompactFlash specific PIO modes 5/6 and MWDMA modes 3/4.
> 
> Since there were no PIO5 capable hard drives produced and one would also need
> 66 MHz IDE clock to actually get the difference WRT the address setup timings
> programmed, I decided to simply replace the old non-standard PIO mode 5 timings
> with the CFA specified ones.
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> 
> ---
> Changes since the previous take:
> - added check for CFA modes to 'sl82c105' driver;
> - added identify word 163 copying to ide_driveid_update();
> - made change based on just posted ide_config_drive_speed() fixlet...

applied fixing checkpatch.pl complaint while at it:

ERROR: space prohibited after that open parenthesis '('
#199: FILE: drivers/ide/sl82c105.c:64:
+       if ( (pio > 2 || ata_id_has_iordy(drive->id)) && ]

> --- linux-2.6.orig/drivers/ide/sl82c105.c
> +++ linux-2.6/drivers/ide/sl82c105.c
> @@ -61,7 +61,8 @@ static unsigned int get_pio_timings(ide_
>  	if (cmd_off == 0)
>  		cmd_off = 1;
>  
> -	if (pio > 2 || ata_id_has_iordy(drive->id))
> +	if ( (pio > 2 || ata_id_has_iordy(drive->id)) &&
> +	    !(pio > 4 && ata_id_is_cfa(drive->id)))
>  		iordy = 0x40;

I guess that it would later make sense to abstract this code into
ata_id_needs_iordy(id, pio) helper + cleanup sl82c105 and at91_ide
host drivers accordingly?