From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] tracing: use raw spinlocks for trace_vprintk
Date: Wed, 11 Mar 2009 19:26:56 +0100 [thread overview]
Message-ID: <20090311182656.GA23739@elte.hu> (raw)
In-Reply-To: <1236754764.22914.3680.camel@twins>
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, 2009-03-10 at 21:26 -0400, Steven Rostedt wrote:
>
> > commit 80370cb758e7ca2692cd9fb5e413d970b1f4b2b2
> > Author: Steven Rostedt <srostedt@redhat.com>
> > Date: Tue Mar 10 17:16:35 2009 -0400
> >
> > tracing: use raw spinlocks for trace_vprintk
> >
> > Impact: prevent locking up by lockdep tracer
> >
> > The lockdep tracer uses trace_vprintk and thus trace_vprintk can not
> > call back into lockdep without locking up.
>
> Hmm, I did this when I posted the lockdep tracepoints, so someone then
> did a bad copy/paste job when renaming ftrace_printk or something?
>
> See efed792d6738964f399a508ef9e831cd60fa4657
What's the conclusion in this thread? I'm holding the pull
until there's agreement.
Ingo
next prev parent reply other threads:[~2009-03-11 18:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 1:26 [GIT PULL] tracing: use raw spinlocks for trace_vprintk Steven Rostedt
2009-03-11 6:59 ` Peter Zijlstra
2009-03-11 7:18 ` Frederic Weisbecker
2009-03-11 14:00 ` Steven Rostedt
2009-03-11 14:01 ` Steven Rostedt
2009-03-11 14:04 ` Frederic Weisbecker
2009-03-11 13:57 ` Steven Rostedt
2009-03-11 18:26 ` Ingo Molnar [this message]
2009-03-11 18:32 ` Steven Rostedt
2009-03-11 19:45 ` Peter Zijlstra
2009-03-11 19:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090311182656.GA23739@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.