From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LhVmJ-0006wz-VV for mharc-grub-devel@gnu.org; Wed, 11 Mar 2009 17:15:52 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhVmI-0006vI-1H for grub-devel@gnu.org; Wed, 11 Mar 2009 17:15:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhVmG-0006ud-HI for grub-devel@gnu.org; Wed, 11 Mar 2009 17:15:49 -0400 Received: from [199.232.76.173] (port=35005 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhVmG-0006ua-CD for grub-devel@gnu.org; Wed, 11 Mar 2009 17:15:48 -0400 Received: from aybabtu.com ([69.60.117.155]:48856) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LhVmG-0001MF-2y for grub-devel@gnu.org; Wed, 11 Mar 2009 17:15:48 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LhVdx-0008Ak-Un for grub-devel@gnu.org; Wed, 11 Mar 2009 22:07:14 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LhVm9-0007p0-Rl for grub-devel@gnu.org; Wed, 11 Mar 2009 22:15:41 +0100 Date: Wed, 11 Mar 2009 22:15:41 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090311211541.GC29956@thorin> References: <49AB29BA.6040609@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49AB29BA.6040609@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: ELF bugfixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2009 21:15:50 -0000 On Mon, Mar 02, 2009 at 01:35:06AM +0100, phcoder wrote: > + * include/grub/elf.h: added missing attributes This should be a bit more descriptive. > for (i = 0; i < ehdr->e_phnum; i++) > if (phdr(i)->p_type == PT_LOAD && phdr(i)->p_filesz != 0) > { > - if (phdr(i)->p_paddr < phdr(lowest_segment)->p_paddr) > + if (lowest_segment == -1 > + || phdr(i)->p_paddr < phdr(lowest_segment)->p_paddr) > lowest_segment = i; > - if (phdr(i)->p_paddr > phdr(highest_segment)->p_paddr) > + if (highest_segment == -1 > + || phdr(i)->p_paddr > phdr(highest_segment)->p_paddr) > highest_segment = i; > } Why? > - grub_multiboot_payload_entry_offset = ehdr->e_entry - phdr(lowest_segment)->p_vaddr; > + grub_multiboot_payload_entry_offset = ehdr->e_entry - phdr(lowest_segment)->p_paddr; Are you sure about this? IIRC e_entry is in the virtual address space. I think we had some trouble with this (with NetBSD?), which lead to the current use of p_vaddr in this line. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."