All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 3/4] tracing: move binary buffers into per cpu directory
Date: Thu, 12 Mar 2009 22:16:34 -0700	[thread overview]
Message-ID: <20090312221634.407c82ad.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090313050521.535041167@goodmis.org>

On Fri, 13 Mar 2009 01:04:49 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:

>  	if (!entry)
>  		pr_warning("Could not create debugfs 'trace' entry\n");
> +
> +	entry = debugfs_create_file("trace_pipe_raw", 0444, d_cpu,
> +				    (void *) cpu, &tracing_buffers_fops);
> +	if (!entry)
> +		pr_warning("Could not create debugfs 'trace_pipe_raw' entry\n");

Maybe we should just do the warning in debugfs_create_file().  It's hard to
think of a scenario where we wouldn't want this failure to be reported.

If there is such a scenario then debugfs_create_file_nowarn() beckons.

  reply	other threads:[~2009-03-13  5:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-13  5:04 [PATCH 0/4] [GIT PULL] updates for tip/tracing/ftrace Steven Rostedt
2009-03-13  5:04 ` [PATCH 1/4] tracing: left align location header in stack_trace Steven Rostedt
2009-03-13  5:04 ` [PATCH 2/4] tracing: add comment for use of double __builtin_consant_p Steven Rostedt
2009-03-13  5:04 ` [PATCH 3/4] tracing: move binary buffers into per cpu directory Steven Rostedt
2009-03-13  5:16   ` Andrew Morton [this message]
2009-03-13  5:04 ` [PATCH 4/4] softirq: no need to have SOFTIRQ in softirq name Steven Rostedt
2009-03-13  5:17   ` Andrew Morton
2009-03-13  5:40   ` Jaswinder Singh Rajput
2009-03-13  5:30 ` [PATCH 0/4] [GIT PULL] updates for tip/tracing/ftrace Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090312221634.407c82ad.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.