From: Greg KH <greg@kroah.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: afleming@freescale.com, Greg KH <gregkh@suse.de>,
Johns Daniel <johns.daniel@gmail.com>,
stable@kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Remove extra semicolon in fsl_soc.c
Date: Thu, 12 Mar 2009 23:03:18 -0700 [thread overview]
Message-ID: <20090313060318.GA19770@kroah.com> (raw)
In-Reply-To: <fa686aa40903110903h1077860dt45c1a5aecd2ef42f@mail.gmail.com>
On Wed, Mar 11, 2009 at 10:03:22AM -0600, Grant Likely wrote:
> On Wed, Mar 11, 2009 at 9:50 AM, Johns Daniel <johns.daniel@gmail.com> wrote:
> > A semicolon at the end of the macro means that the for loop has an
> > empty body, and so TSEC/MDIO will not work with older device trees.
> >
> > This fix only applies to 2.6.28; apparently, this code is gone for
> > 2.6.29, according to Grant Likely!
> >
> > Signed-off-by: Johns Daniel <johns.daniel@gmail.com>
>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
>
> Greg: Andy Flemming should probably confirm this, but I think this
> one should be backported to the stable series.
Hm, this patch is line-wrapped and tabs are stripped, so I can't apply
it :(
Anyone care to resend it?
thanks,
greg k-h
> > ---
> > --- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig 2009-02-20
> > 16:41:27.000000000 -0600
> > +++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c 2009-03-10
> > 15:56:47.000000000 -0500
> > @@ -257,7 +257,7 @@
> > gfar_mdio_of_init_one(np);
> >
> > /* try the deprecated version */
> > - for_each_compatible_node(np, "mdio", "gianfar");
> > + for_each_compatible_node(np, "mdio", "gianfar")
> > gfar_mdio_of_init_one(np);
> >
> > return 0;
> > ---
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@ozlabs.org
> > https://ozlabs.org/mailman/listinfo/linuxppc-dev
> >
>
>
>
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
prev parent reply other threads:[~2009-03-13 6:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 15:50 [PATCH] powerpc: Remove extra semicolon in fsl_soc.c Johns Daniel
2009-03-11 16:03 ` Grant Likely
2009-03-11 16:05 ` [stable] " Greg KH
2009-03-13 6:03 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090313060318.GA19770@kroah.com \
--to=greg@kroah.com \
--cc=afleming@freescale.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@suse.de \
--cc=johns.daniel@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.