All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com,
	markus.t.metzger@gmail.com, roland@redhat.com,
	eranian@googlemail.com, oleg@redhat.com, juan.villacis@intel.com,
	ak@linux.jf.intel.com
Subject: Re: [patch 1/5] x86, bts: detect size of DS fields
Date: Fri, 13 Mar 2009 12:03:57 +0100	[thread overview]
Message-ID: <20090313110357.GC31094@elte.hu> (raw)
In-Reply-To: <20090313104218.A30096@sedona.ch.intel.com>


Applied your patches to tip:tracing/hw-branch-tracer, thanks 
Markus!

I did a small cleanup patch - see it in this thread.

One detail i noticed:

static DEFINE_PER_CPU(struct ds_configuration, ds_cfg_array);

That PER_CPU indirection should be removed - it's enough to have 
system-wide configuration settings. We dont generally support 
assymetric CPU capabilities in the same system, and the per_cpu 
indirection here slows the code down and obfuscates it.

Thanks,

	Ingo

  parent reply	other threads:[~2009-03-13 11:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-13  9:42 [patch 1/5] x86, bts: detect size of DS fields Markus Metzger
2009-03-13 11:00 ` [tip:tracing/hw-branch-tracing] " Markus Metzger
2009-04-11  6:15   ` Jaswinder Singh Rajput
2009-03-13 11:01 ` [tip:tracing/hw-branch-tracing] x86, bts: cleanups Ingo Molnar
2009-03-13 11:03 ` Ingo Molnar [this message]
2009-03-13 11:09   ` [patch 1/5] x86, bts: detect size of DS fields Ingo Molnar
2009-03-16 14:34   ` Metzger, Markus T
2009-03-17 10:55     ` Ingo Molnar
2009-03-17 12:26       ` Metzger, Markus T
2009-03-17 12:34         ` Ingo Molnar
2009-03-17 12:57           ` Metzger, Markus T
2009-03-17 14:51             ` Metzger, Markus T
2009-03-17 15:15               ` Ingo Molnar
2009-03-18 18:08             ` Metzger, Markus T
2009-03-13 11:06 ` [tip:tracing/hw-branch-tracing] x86, bts: detect size of DS fields, fix Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090313110357.GC31094@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@linux.jf.intel.com \
    --cc=eranian@googlemail.com \
    --cc=hpa@zytor.com \
    --cc=juan.villacis@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.t.metzger@gmail.com \
    --cc=markus.t.metzger@intel.com \
    --cc=oleg@redhat.com \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.