From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frans Pop Subject: Re: [PATCH,v2][1/2] sata-mv: enable HDD led blinking when NCQ is active for GenIIe Date: Fri, 13 Mar 2009 19:19:07 +0100 Message-ID: <200903131919.09525.elendil@planet.nl> References: <200903110813.25650.elendil@planet.nl> <200903130907.15965.elendil@planet.nl> <49BA59FA.1020205@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from Cpsmtpm-eml109.kpnxchange.com ([195.121.3.13]:53676 "EHLO CPSMTPM-EML109.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753047AbZCMSTM (ORCPT ); Fri, 13 Mar 2009 14:19:12 -0400 In-Reply-To: <49BA59FA.1020205@rtr.ca> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mark Lord Cc: linux-arm@vger.kernel.org, linux-ide@vger.kernel.org, Saeed Bishara , Nicolas Pitre , Lennert Buytenhek On Friday 13 March 2009, Mark Lord wrote: > --- old/drivers/ata/sata_mv.c 2009-03-12 10:23:41.000000000 -0400 > +++ new/drivers/ata/sata_mv.c 2009-03-13 09:03:47.000000000 -0400 > @@ -1455,9 +1455,8 @@ > struct ata_port *this_ap = host->ports[port]; > struct mv_port_priv *pp = this_ap->private_data; > > - if (pp->pp_flags & MV_PP_FLAG_EDMA_EN) > - if (pp->pp_flags & MV_PP_FLAG_NCQ_EN) > - return; > + if (pp->pp_flags & MV_PP_FLAG_NCQ_EN) > + return; I expect that if NCQ is disabled using the method I've used so far, the led behavior would still be correct, but... The reason I included the test for both in my patches is that if DMA gets disabled (which IIUC also disables NCQ) only the MV_PP_FLAG_EDMA_EN flag gets unset in mv_stop_edma, and not the NCQ flag (AFAICT). So that would result in blink mode remaining enabled while it shouldn't be. I have so far not tested the led bahavior when DMA is disabled (not even sure if that's possible for a running system). Note that e.g. the last if statement in mv_qc_defer also tests both. Cheers, FJP