From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LiD6y-0001cc-QF for mharc-grub-devel@gnu.org; Fri, 13 Mar 2009 15:32:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LiD6x-0001bg-6E for grub-devel@gnu.org; Fri, 13 Mar 2009 15:32:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LiD6s-0001ZT-Ii for grub-devel@gnu.org; Fri, 13 Mar 2009 15:32:02 -0400 Received: from [199.232.76.173] (port=42230 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LiD6s-0001ZC-6E for grub-devel@gnu.org; Fri, 13 Mar 2009 15:31:58 -0400 Received: from aybabtu.com ([69.60.117.155]:37325) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LiD6r-0000nQ-S9 for grub-devel@gnu.org; Fri, 13 Mar 2009 15:31:58 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LiCyM-0008OB-Q6 for grub-devel@gnu.org; Fri, 13 Mar 2009 20:23:13 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LiD6g-0004Wb-ES for grub-devel@gnu.org; Fri, 13 Mar 2009 20:31:46 +0100 Date: Fri, 13 Mar 2009 20:31:46 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090313193146.GE17068@thorin> References: <499056F4.6000800@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <499056F4.6000800@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Bugfix: directories: not reported as such on case-insensitive fs X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2009 19:32:03 -0000 On Mon, Feb 09, 2009 at 05:16:52PM +0100, phcoder wrote: > - > - if (filetype == GRUB_FSHELP_DIR) > + > + if ((filetype & GRUB_FSHELP_TYPE_MASK) == GRUB_FSHELP_DIR) Please don't remove those spaces, they're intentional (see http://www.gnu.org/prep/standards/html_node/Formatting.html#Formatting) > + * include/grub/fshelp.h: included definition of GRUB_FSHELP_TYPE_MASK > + and GRUB_FSHELP_FLAGS_MASK This should be something like: * file (macro1, macro2): Define. or similar. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."