From: Greg KH <greg@kroah.com>
To: Peter Teoh <htmldeveloper@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: kernel_thread() usage found in staging
Date: Fri, 13 Mar 2009 14:24:28 -0700 [thread overview]
Message-ID: <20090313212428.GA27344@kroah.com> (raw)
In-Reply-To: <804dabb00903130126m79272087xd2fd452e2712abac@mail.gmail.com>
On Fri, Mar 13, 2009 at 04:26:27PM +0800, Peter Teoh wrote:
> >From Documentation/feature_removal_schedule.txt, it is well-known that
> kernel_thread() API usage is discouraged, but in staging we still
> routinely see its use. Perhaps the original driver owner have
> overlooked this?
Yes, they probably didn't realize this and some of this code predates
the kthread code.
> ./rt2870/common/2870_rtmp_init.c:
> pid_number = kernel_thread(MlmeThread, pAd, CLONE_VM);
> pid_number = kernel_thread(RTUSBCmdThread, pAd, CLONE_VM);
> pid_number = kernel_thread(TimerQThread, pAd, CLONE_VM);
>
> ./usbip/usbip_common.c:
> retval = kernel_thread(usbip_thread, (void *)&ud->tcp_rx, 0);
> retval = kernel_thread(usbip_thread, (void *)&ud->tcp_tx, 0);
>
> ./usbip/usbip_event.c:
> kernel_thread(usbip_thread, (void *)eh, 0);
>
> ./epl/ShbIpc-LinuxKernel.c:
> kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p,
> kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,
>
> ./epl/EplSdoUdpu.c:
> kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g, CLONE_KERNEL);
Patches are gladly accepted to clean this up.
thanks,
greg k-h
next prev parent reply other threads:[~2009-03-13 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 8:26 kernel_thread() usage found in staging Peter Teoh
2009-03-13 21:24 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-18 13:30 Daniel Krüger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090313212428.GA27344@kroah.com \
--to=greg@kroah.com \
--cc=htmldeveloper@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.