From: Rusty Russell <rusty@rustcorp.com.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Mike Travis <travis@sgi.com>
Subject: Re: [PULL] x86 cpumask work
Date: Fri, 13 Mar 2009 23:42:42 +1030 [thread overview]
Message-ID: <200903132342.42813.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090313053214.GA21183@elte.hu>
On Friday 13 March 2009 16:02:14 Ingo Molnar wrote:
>
> another box crashed too, with:
Interestingly, I needed both these patches. And *both* generated compile
warnings. Grr...
Rusty.
Subject: cpumask: fix CONFIG_DEBUG_PER_CPU_MAPS=y cpumask_of_node version.
Impact: Fix crash
c032ef60d1aa9af33730b7a35bbea751b131adc1 "cpumask: convert
node_to_cpumask_map[] to cpumask_var_t" didn't get this one
conversion. There was a compile warning, but I missed it.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
--- a/arch/x86/mm/numa.c
+++ b/arch/x86/mm/numa.c
@@ -61,7 +61,7 @@ const cpumask_t *cpumask_of_node(int nod
dump_stack();
return cpu_online_mask;
}
- return &node_to_cpumask_map[node];
+ return node_to_cpumask_map[node];
}
EXPORT_SYMBOL(cpumask_of_node);
#endif
next prev parent reply other threads:[~2009-03-13 13:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 4:23 [PULL] x86 cpumask work Rusty Russell
2009-03-12 10:26 ` Ingo Molnar
2009-03-12 10:37 ` Ingo Molnar
2009-03-12 22:54 ` Rusty Russell
2009-03-13 0:57 ` Ingo Molnar
2009-03-13 2:46 ` Rusty Russell
2009-03-13 3:20 ` Ingo Molnar
2009-03-13 4:34 ` Rusty Russell
2009-03-13 4:55 ` Ingo Molnar
2009-03-13 5:27 ` Ingo Molnar
2009-03-13 5:32 ` Ingo Molnar
2009-03-13 6:44 ` Rusty Russell
2009-03-13 13:12 ` Rusty Russell [this message]
2009-03-13 13:45 ` [tip:cpus4096] cpumask: convert node_to_cpumask_map[] to cpumask_var_t Rusty Russell
2009-03-13 15:27 ` [PULL] x86 cpumask work Ingo Molnar
2009-03-15 2:56 ` Rusty Russell
2009-03-15 6:00 ` Ingo Molnar
2009-03-16 3:03 ` Rusty Russell
2009-03-16 8:48 ` Ingo Molnar
2009-03-17 4:20 ` Rusty Russell
2009-03-17 10:51 ` Ingo Molnar
2009-03-17 21:27 ` Rusty Russell
2009-03-18 8:51 ` [tip:cpus4096] cpumask: fix CONFIG_CPUMASK_OFFSTACK=y cpu hotunplug crash Rusty Russell
2009-03-13 13:13 ` [PATCH] Move numa_node_id default implementation to topology.h Rusty Russell
2009-03-13 13:45 ` [tip:cpus4096] numa, cpumask: move " Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2009-03-17 18:56 [PULL] x86 cpumask work Cliff Wickman
2009-03-17 21:52 ` Rusty Russell
2009-03-18 12:57 ` Cliff Wickman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903132342.42813.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.