All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] example/standalone: introduce STANDALONE_LOAD_ADDR
Date: Sat, 14 Mar 2009 09:41:58 -0400	[thread overview]
Message-ID: <200903140942.00465.vapier@gentoo.org> (raw)
In-Reply-To: <20090314131901.GB23599@game.jcrosoft.org>

On Saturday 14 March 2009 09:19:01 Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 09:12 Sat 14 Mar     , Mike Frysinger wrote:
> > On Saturday 14 March 2009 08:45:56 Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > On 07:37 Sat 14 Mar     , Mike Frysinger wrote:
> > > > On Saturday 14 March 2009 07:13:02 Jean-Christophe wrote:
> > > > > that could be overwrite in following order
> > > > > ARCH
> > > > > CPU
> > > > > SOC
> > > > > BOARD
> > > > >
> > > > > via the corresponding config.mk
> > > >
> > > > the idea sounds fine to me ...
> > > >
> > > > > the value could be exported to the environment to reduce the user
> > > > > mistake when they try to use example's standalone application
> > > >
> > > > i dont really understand what you're trying to say here.  could you
> > > > elaborate so we can fix up the changelog ?
> > >
> > > as example generate via the config.h a env var name
> > > standalone_load_addr automaticly so the end user will just have to
> > > built it, load it and run it
> >
> > i still dont get it.  config.h is the shortcut header to get at the board
> > config.h.  defines do not randomly get exported from there into the
> > environment.  the autoconf.mk mechanism only exports CONFIG_* stuff.
>
> via the board config.h you could add default extra env settings by doing
> this as example
>
> #define CONFIG_EXTRA_ENV_SETTINGS
> "standalone_load_addr="xstr(STANDALONE_LOAD_ADDR)

so you're talking about the u-boot runtime environment, not the u-boot build 
environment.

i dont think your example here is the whole story.  nothing moves the u-boot 
make var STANDALONE_LOAD_ADDR from the env into CPPFLAGS / define.  so you 
would also need to add to some .mk somewhere:
CPPFLAGS += -DSTANDALONE_LOAD_ADDR=$(STANDALONE_LOAD_ADDR)

probably best if you just deleted that last paragraph from the commit message 
since it's too vague to be useful imo.
-mike

  reply	other threads:[~2009-03-14 13:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04  9:11 [U-Boot] [PATCH 1/1] example: introduce EXAMPLE_LOAD_ADDR Jean-Christophe PLAGNIOL-VILLARD
2009-03-08 22:37 ` Wolfgang Denk
2009-03-14 11:13   ` [U-Boot] [PATCH V2] example/standalone: introduce STANDALONE_LOAD_ADDR Jean-Christophe PLAGNIOL-VILLARD
2009-03-14 11:37     ` Mike Frysinger
2009-03-14 12:45       ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-14 13:12         ` Mike Frysinger
2009-03-14 13:19           ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-14 13:41             ` Mike Frysinger [this message]
2009-03-14 21:31         ` Wolfgang Denk
2009-03-15 10:51           ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-15 18:29             ` Wolfgang Denk
2009-03-15 19:23               ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-15 21:47               ` Mike Frysinger
2009-03-15 21:49                 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903140942.00465.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.