Re: [patch 2.6.29-rc8-omap] twl4030 power scripts, initsection fixups

[David Brownell <david-b@pacbell.net>]

On Saturday 14 March 2009, Felipe Balbi wrote:
> > 
> > Remove section mismatch warnings from twl4030 power script
> > declaration ... unfortunately, this use-once data can't live
> > in initdata sections (or initconst) until some driver stacks
> > (starting with I2C) have better support for non-hotpluggable
> > componentry.
> 
> should you update this with the following ?

I didn't see any section mismatch warnings from this goofage.  ;)

But, yes this looks wrong too.  Resend with your s-o-b ...


> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -66,7 +66,7 @@ static u8 triton_next_free_address = 0x2b;
>  #define KEY_1                  0xC0
>  #define KEY_2                  0x0C
>  
> -static int __init twl4030_write_script_byte(u8 address, u8 byte)
> +static int twl4030_write_script_byte(u8 address, u8 byte)
>  {
>         int err;
> 
> 	... deleted similar changes ...


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html