From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: Broken SDP parsing?
Date: Sat, 14 Mar 2009 10:29:26 -0300 [thread overview]
Message-ID: <20090314132926.GA17305@jh-x301> (raw)
In-Reply-To: <1236991168.32264.6353.camel@cookie.hadess.net>
Hi Bastien,
On Sat, Mar 14, 2009, Bastien Nocera wrote:
> > Thanks. I had to fix the following warning in the cups patch, but
> > otherwise they were fine:
> > main.c: In function ‘device_get_ieee1284_id’:
> > main.c:129: error: ‘id’ may be used uninitialized in this function
>
> I didn't see this. Must be my gcc being low on warnings.
Yeah, you'll need to compile with --disable-debug to get the full list
of warnings since the optimization level seems to affect them.
> I did notice a "return FALSE" in device_get_ieee1284_id(), when it
> should be a "return NULL" though. Could you get that pushed?
Done.
Johan
prev parent reply other threads:[~2009-03-14 13:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 1:00 Broken SDP parsing? Bastien Nocera
2009-03-08 14:46 ` Bastien Nocera
2009-03-09 13:08 ` Luiz Augusto von Dentz
2009-03-09 14:14 ` Bastien Nocera
2009-03-09 14:32 ` Luiz Augusto von Dentz
2009-03-09 14:53 ` Luiz Augusto von Dentz
2009-03-09 15:25 ` Bastien Nocera
2009-03-09 16:40 ` Luiz Augusto von Dentz
2009-03-09 17:09 ` Bastien Nocera
2009-03-09 18:04 ` Johan Hedberg
2009-03-09 19:29 ` Port CUPS discovery to BlueZ 4.x (Re: Broken SDP parsing?) Bastien Nocera
2009-03-13 15:37 ` Broken SDP parsing? Bastien Nocera
2009-03-13 18:15 ` Johan Hedberg
2009-03-14 0:39 ` Bastien Nocera
2009-03-14 13:29 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090314132926.GA17305@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.