From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LiVAU-0005aO-WC for mharc-grub-devel@gnu.org; Sat, 14 Mar 2009 10:48:55 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LiVAT-0005aJ-G5 for grub-devel@gnu.org; Sat, 14 Mar 2009 10:48:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LiVAO-0005Zz-La for grub-devel@gnu.org; Sat, 14 Mar 2009 10:48:52 -0400 Received: from [199.232.76.173] (port=33340 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LiVAO-0005Zw-JL for grub-devel@gnu.org; Sat, 14 Mar 2009 10:48:48 -0400 Received: from aybabtu.com ([69.60.117.155]:58075) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LiVAO-000137-8l for grub-devel@gnu.org; Sat, 14 Mar 2009 10:48:48 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LiV1p-000358-MB for grub-devel@gnu.org; Sat, 14 Mar 2009 15:39:58 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LiVAK-0003Wn-9W for grub-devel@gnu.org; Sat, 14 Mar 2009 15:48:44 +0100 Date: Sat, 14 Mar 2009 15:48:44 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090314144844.GA13451@thorin> References: <4992ABA6.7040200@gmail.com> <49BAEDAD.3030704@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49BAEDAD.3030704@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [Patch] Move multiboot helpers out of the kernel X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Mar 2009 14:48:53 -0000 On Sat, Mar 14, 2009 at 12:35:09AM +0100, phcoder wrote: > Index: conf/i386-ieee1275.rmk > =================================================================== > --- conf/i386-ieee1275.rmk (revision 2030) > +++ conf/i386-ieee1275.rmk (working copy) > @@ -126,10 +126,12 @@ > > # For _multiboot.mod. > _multiboot_mod_SOURCES = loader/ieee1275/multiboot2.c \ > + loader/i386/multiboot_helper.S \ multiboot_helper.S is not being used on i386-ieee1275 AFAICT > - /* Unload all modules and stop the floppy driver. */ > - call EXT_C(grub_dl_unload_all) grub_dl_unload_all() just disappeared. Is this intentional? I tend to agree that grub_dl_unload_all() is a waste of time, but this should be discussed separately. > - call EXT_C(grub_stop_floppy) grub_stop_floppy() was moved to grub_multiboot_boot(). I think grub_machine_fini() would be the more appropiate place. I'm not sure why it was in those asm snippets to begin with (does someone know?). Also, grub_unix_real_boot() completely disappeared with your patch. This seems to break *BSD. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."