From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LiWsM-0003YE-Rg for mharc-grub-devel@gnu.org; Sat, 14 Mar 2009 12:38:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LiWsK-0003Vj-Ei for grub-devel@gnu.org; Sat, 14 Mar 2009 12:38:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LiWsF-0003RD-UW for grub-devel@gnu.org; Sat, 14 Mar 2009 12:38:16 -0400 Received: from [199.232.76.173] (port=53362 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LiWsF-0003R3-O1 for grub-devel@gnu.org; Sat, 14 Mar 2009 12:38:11 -0400 Received: from mx20.gnu.org ([199.232.41.8]:29955) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LiWsF-00066c-C5 for grub-devel@gnu.org; Sat, 14 Mar 2009 12:38:11 -0400 Received: from aybabtu.com ([69.60.117.155]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LiWsA-0000tP-GA for grub-devel@gnu.org; Sat, 14 Mar 2009 12:38:06 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LiWjX-0003MK-T1 for grub-devel@gnu.org; Sat, 14 Mar 2009 17:29:12 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LiWs1-0003eS-Iu for grub-devel@gnu.org; Sat, 14 Mar 2009 17:37:57 +0100 Date: Sat, 14 Mar 2009 17:37:57 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090314163757.GA13991@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] Bug fix for ext2.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Mar 2009 16:38:17 -0000 On Sun, Mar 15, 2009 at 12:16:23AM +0800, Bean wrote: > Hi, > > I've discovered a bug in ext2.c, inside grub_ext2_mount. The mount > function must return GRUB_ERR_BAD_FS if something goes wrong, because > grub_fs_probe would stop as soon as it sees a non-GRUB_ERR_BAD_FS > error, thus preventing other fs driver from detecting the correct fs > type. This patch fixes the problem. I think current behaviour is correct. If a failure is triggered by grub_disk_read(), from grub_fs_probe perspective it means something is fucked up other than just "this is not the FS we're looking for", so it should be aware of the difference. Or is grub_ext2_read_inode() failure the one that's causing trouble for you? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."