From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Vegard Nossum <vegard.nossum@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] x86: cpu/intel.c cleanup
Date: Sat, 14 Mar 2009 18:04:45 +0100 [thread overview]
Message-ID: <20090314170445.GF31930@elte.hu> (raw)
In-Reply-To: <1237046650.4546.30.camel@ht.satnam>
* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> On Sat, 2009-03-14 at 16:31 +0100, Ingo Molnar wrote:
> > >
> > > I don't really like this change (last hunk). Doesn't it seem a
> > > bit pointless? It breaks the symmetry with the masked CPUID
> > > levels at the beginning of the function. If somebody wants to
> > > add something else to this function, it might have to be
> > > reindented again. Or is there a problem with too long lines
> > > here?
> >
> > yes, it would be cleaner to put the whole family 15 branch into
> > a helper inline function instead.
> >
>
> OK, better I keep it unchanged :-)
Why not implement the cleanup i suggested?
Ingo
next prev parent reply other threads:[~2009-03-14 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 12:41 [PATCH -tip] x86: cpu/intel.c cleanup Jaswinder Singh Rajput
2009-03-14 13:11 ` Sam Ravnborg
2009-03-14 13:20 ` Ingo Molnar
2009-03-14 13:37 ` Jaswinder Singh Rajput
2009-03-14 14:00 ` Vegard Nossum
2009-03-14 15:31 ` Ingo Molnar
2009-03-14 16:04 ` Jaswinder Singh Rajput
2009-03-14 17:04 ` Ingo Molnar [this message]
2009-03-14 18:05 ` Jaswinder Singh Rajput
2009-03-15 5:55 ` Ingo Molnar
2009-03-14 13:21 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090314170445.GF31930@elte.hu \
--to=mingo@elte.hu \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=vegard.nossum@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.