From: Matthew Wilcox <matthew@wil.cx>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Matthew Wilcox <willy@linux.intel.com>,
linux-scsi@vger.kernel.org, Martin Petersen <mkp@mkp.net>
Subject: Re: [PATCH 2/2] sd: Try READ CAPACITY 16 first for SBC-2 devices
Date: Sat, 14 Mar 2009 17:47:00 -0600 [thread overview]
Message-ID: <20090314234700.GF14127@parisc-linux.org> (raw)
In-Reply-To: <1237073695.3907.84.camel@localhost.localdomain>
On Sat, Mar 14, 2009 at 06:34:55PM -0500, James Bottomley wrote:
> Actually, afraid not, you're trapped in the confusing maze of ASC/ASCQ
> codes, all sounding alike but meaning slightly different things:
> 0x24/0x00 is Invalid Field in CDB. The problem I'm having is 0x20/00
> (Invalid Command Operation Code).
Ooh, so close!
> This will fix it, though ... I'll just merge it into your patch.
That's fine. I'd like it if we had a set of inline functions called things
like 'invalid_command_operation_code()', but we don't, so I have no
objections to this patch. I think merging it in is probably best.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2009-03-14 23:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 18:20 Support READ CAPACITY 16 on more drives Matthew Wilcox
2009-03-12 18:20 ` [PATCH 1/2] sd: Refactor sd_read_capacity() Matthew Wilcox
2009-03-12 18:35 ` Martin K. Petersen
2009-03-13 21:29 ` James Bottomley
2009-03-13 21:45 ` Martin K. Petersen
2009-03-14 1:19 ` Matthew Wilcox
2009-03-14 13:40 ` James Bottomley
2009-03-12 18:20 ` [PATCH 2/2] sd: Try READ CAPACITY 16 first for SBC-2 devices Matthew Wilcox
2009-03-14 20:41 ` James Bottomley
2009-03-14 22:48 ` Matthew Wilcox
2009-03-14 23:34 ` James Bottomley
2009-03-14 23:47 ` Matthew Wilcox [this message]
2009-03-15 2:36 ` Douglas Gilbert
2009-03-15 3:30 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090314234700.GF14127@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@mkp.net \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.