From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LibOS-0007Ec-8z for mharc-grub-devel@gnu.org; Sat, 14 Mar 2009 17:27:44 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LibOQ-0007CB-Ob for grub-devel@gnu.org; Sat, 14 Mar 2009 17:27:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LibOP-0007BP-Ns for grub-devel@gnu.org; Sat, 14 Mar 2009 17:27:41 -0400 Received: from [199.232.76.173] (port=46838 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LibOP-0007BM-II for grub-devel@gnu.org; Sat, 14 Mar 2009 17:27:41 -0400 Received: from mail.nexedi.com ([91.121.25.85]:38558 helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LibOP-0002a6-6m for grub-devel@gnu.org; Sat, 14 Mar 2009 17:27:41 -0400 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 840393D9EF for ; Sat, 14 Mar 2009 22:27:39 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sun, 15 Mar 2009 06:27:34 +0900 User-Agent: KMail/1.9.10 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903150627.34301.okuji@enbug.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Bug fix for ext2.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Mar 2009 21:27:43 -0000 On Sunday 15 March 2009 01:16:23 Bean wrote: > Hi, > > I've discovered a bug in ext2.c, inside grub_ext2_mount. The mount > function must return GRUB_ERR_BAD_FS if something goes wrong, because > grub_fs_probe would stop as soon as it sees a non-GRUB_ERR_BAD_FS > error, thus preventing other fs driver from detecting the correct fs > type. This patch fixes the problem. This patch ignores any kind of failure. That's a problem. If you only convert GRUB_ERR_OUT_OF_RANGE to GRUB_ERR_BAD_FS, I agree. Regards, Okuji