All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/7] xfs: cleanup xlog_bread
Date: Sun, 15 Mar 2009 18:53:56 +1100	[thread overview]
Message-ID: <20090315075356.GS26138@disturbed> (raw)
In-Reply-To: <20090220085229.488121000@bombadil.infradead.org>

On Fri, Feb 20, 2009 at 03:52:11AM -0500, Christoph Hellwig wrote:
> Most callers of xlog_bread need to call xlog_align to get the actual offset.
> Consolidate that call into the main xlog_bread and provide a _xlog_bread
> for those few that don't want the actual offset.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

.....

>   * nbblks should be uint, but oh well.  Just want to catch that 32-bit length.
>   */
> -int
> -xlog_bread(
> +STATIC int
> +_xlog_bread(
>  	xlog_t		*log,
>  	xfs_daddr_t	blk_no,
>  	int		nbblks,
> @@ -137,6 +155,24 @@ xlog_bread(
>  	return error;
>  }

xlog_bread_noalign().

Otherwise looks good. Consider it:

Reviewed-by: Dave Chinner <david@fromorbit.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2009-03-15  7:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20  8:52 [PATCH 0/7] a couple more random cleanups for 2.6.30 Christoph Hellwig
2009-02-20  8:52 ` [PATCH 1/7] xfs: cleanup log unmount handling Christoph Hellwig
2009-03-15  7:49   ` Dave Chinner
2009-02-20  8:52 ` [PATCH 2/7] xfs: remove another leftover of the old inode log item format Christoph Hellwig
2009-03-15  7:49   ` Dave Chinner
2009-02-20  8:52 ` [PATCH 3/7] xfs: cleanup xlog_recover_do_trans Christoph Hellwig
2009-03-15  7:50   ` Dave Chinner
2009-02-20  8:52 ` [PATCH 4/7] xfs: cleanup xlog_bread Christoph Hellwig
2009-02-22 22:48   ` Josef 'Jeff' Sipek
2009-02-24 14:40     ` Christoph Hellwig
2009-03-15  7:53   ` Dave Chinner [this message]
2009-02-20  8:52 ` [PATCH 5/7] xfs: kill vn_atime_* helpers Christoph Hellwig
2009-03-15  7:54   ` Dave Chinner
2009-02-20  8:52 ` [PATCH 6/7] xfs: kill VN_BAD Christoph Hellwig
2009-03-15  7:54   ` Dave Chinner
2009-02-20  8:52 ` [PATCH 7/7] xfs: factor out code to find the longest free extent in the AG Christoph Hellwig
2009-03-15  7:58   ` Dave Chinner
2009-03-16  7:27     ` Christoph Hellwig
2009-03-16  8:46 ` [PATCH 0/7] a couple more random cleanups for 2.6.30 Christoph Hellwig
2009-03-16 20:55   ` Felix Blyakher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090315075356.GS26138@disturbed \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.