From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: xfs: use generic Posix ACL code
Date: Sun, 15 Mar 2009 19:18:56 +1100 [thread overview]
Message-ID: <20090315081856.GW26138@disturbed> (raw)
In-Reply-To: <20090304173008.GA32471@infradead.org>
On Wed, Mar 04, 2009 at 12:30:08PM -0500, Christoph Hellwig wrote:
> On Fri, Feb 20, 2009 at 03:51:17PM -0500, Christoph Hellwig wrote:
> > This patch rips out the XFS ACL handling code and uses the generic
> > fs/posix_acl.c code instead. The ondisk format is of course left
> > unchanged.
> >
> > This also introduces the same ACL caching all other Linux filesystems do
> > by adding pointers to the acl and default acl in struct xfs_inode.
>
> FYI: there was one hunk that slipped into another patch so that it
> was missing in this one. Correct one below:
>
>
> This patch rips out the XFS ACL handling code and uses the generic
> fs/posix_acl.c code instead. The ondisk format is of course left
> unchanged.
>
> This also introduces the same ACL caching all other Linux filesystems do
> by adding pointers to the acl and default acl in struct xfs_inode.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I haven't done an in-depth review of this, but i can't find any
glaring problems while reading over the diff. So, in the interests of
moving this forward, you can add a:
Acked-by: Dave Chinner <david@fromorbit.com>
to this. I think at this point it probably should be pushed into the
dev tree and aimed at 2.6.31....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-03-15 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 20:51 xfs: use generic Posix ACL code Christoph Hellwig
2009-03-04 17:30 ` Christoph Hellwig
2009-03-15 8:18 ` Dave Chinner [this message]
2009-06-08 20:36 ` Eric Sandeen
2009-06-09 9:01 ` Christoph Hellwig
2009-06-09 16:40 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090315081856.GW26138@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.