From: Stuart Brady <sdbrady@ntlworld.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] [linux-user] Fix ioctl code generation macros
Date: Sun, 15 Mar 2009 09:45:17 +0000 [thread overview]
Message-ID: <20090315094517.GA24497@miranda.arrow> (raw)
In-Reply-To: <1237081212.589.23.camel@coalu.atr>
On Sun, Mar 15, 2009 at 02:40:11AM +0100, Lionel Landwerlin wrote:
> Of course, the problem is solved if you're saving the result of the
> TARGET_IO* macros in an unsigned integer.
>
> So here is a little patch that forces TARGET_IO* macros to output
> abi_long sized integers.
Surely the value currently produced by TARGET_IOC() *is* an unsigned int
(provided you use the direction macros)? I'm not sure if any arch will
ever need more than 32 bits here, but even with the cast to abi_long,
the high bits would be truncated before the cast.
target_cmd in IOCTLEntry is an unsigned int, but the command is also
passed around as an abi_long is some places... I couldn't see any code
that's currently affected by this, though -- did I miss something?
Cheers,
--
Stuart Brady
prev parent reply other threads:[~2009-03-15 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 1:40 [Qemu-devel] [PATCH] [linux-user] Fix ioctl code generation macros Lionel Landwerlin
2009-03-15 9:45 ` Stuart Brady [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090315094517.GA24497@miranda.arrow \
--to=sdbrady@ntlworld.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.