From: Jean Delvare <khali@linux-fr.org>
To: LMML <linux-media@vger.kernel.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>, Trent Piepho <xyzzy@speakeasy.org>
Subject: [PATCH] Fix notify callback prototype
Date: Sun, 15 Mar 2009 10:20:45 +0100 [thread overview]
Message-ID: <20090315102045.5ea33d34@hyperion.delvare> (raw)
I see the following warning when building the zoran driver:
v4l/zoran_card.c: In function 'zoran_probe':
v4l/zoran_card.c:1243: warning: assignment from incompatible pointer type
Fixing the notify callback prototype solves it.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Trent Piepho <xyzzy@speakeasy.org>
---
linux/drivers/media/video/zoran/zoran_card.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- v4l-dvb.orig/linux/drivers/media/video/zoran/zoran_card.c 2009-03-15 10:09:47.000000000 +0100
+++ v4l-dvb/linux/drivers/media/video/zoran/zoran_card.c 2009-03-15 10:17:26.000000000 +0100
@@ -1197,7 +1197,7 @@ zoran_setup_videocodec (struct zoran *zr
return m;
}
-static int zoran_subdev_notify(struct v4l2_subdev *sd, unsigned int cmd, void *arg)
+static void zoran_subdev_notify(struct v4l2_subdev *sd, unsigned int cmd, void *arg)
{
struct zoran *zr = to_zoran(sd->v4l2_dev);
@@ -1207,7 +1207,6 @@ static int zoran_subdev_notify(struct v4
GPIO(zr, 7, 0);
else if (cmd == BT819_FIFO_RESET_HIGH)
GPIO(zr, 7, 1);
- return 0;
}
/*
--
Jean Delvare
next reply other threads:[~2009-03-15 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 9:20 Jean Delvare [this message]
2009-03-15 9:39 ` [PATCH] Fix notify callback prototype Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090315102045.5ea33d34@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.