From: Frederic Weisbecker <fweisbec@gmail.com>
To: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
torvalds@linux-foundation.org, vegard.nossum@gmail.com,
jeremy@goop.org, tglx@linutronix.de, mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:core/printk] fix regression from "vsprintf: unify the format decoding layer for its 3 users"
Date: Sun, 15 Mar 2009 15:54:54 +0100 [thread overview]
Message-ID: <20090315145453.GA5105@nowhere> (raw)
In-Reply-To: <tip-adf26f84a62b492e002d3b75af671f23ddd3be0a@git.kernel.org>
On Sat, Mar 14, 2009 at 11:39:47AM +0000, Vegard Nossum wrote:
> Commit-ID: adf26f84a62b492e002d3b75af671f23ddd3be0a
> Gitweb: http://git.kernel.org/tip/adf26f84a62b492e002d3b75af671f23ddd3be0a
> Author: Vegard Nossum <vegard.nossum@gmail.com>
> AuthorDate: Sat, 14 Mar 2009 12:08:50 +0100
> Commit: Ingo Molnar <mingo@elte.hu>
> CommitDate: Sat, 14 Mar 2009 12:37:08 +0100
>
> fix regression from "vsprintf: unify the format decoding layer for its 3 users"
>
> Jeremy Fitzhardinge reported:
>
> > Change fef20d9c1380f04ba9492d6463148db07b413708, "vsprintf:
> > unify the format decoding layer for its 3 users", causes a
> > regression in xenbus which results in no devices getting
> > attached to a new domain.
>
> %.*s is broken - fix it.
>
> Reported-by: Jeremy Fitzhardinge <jeremy@goop.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
>
>
> ---
> lib/vsprintf.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index dc16743..708e505 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -843,7 +843,7 @@ precision:
> spec->precision = 0;
> } else if (*fmt == '*') {
> /* it's the next argument */
> - spec->type = FORMAT_TYPE_WITDH;
> + spec->type = FORMAT_TYPE_PRECISION;
> return ++fmt - start;
> }
> }
Thanks a lot for this patch!
Frederic.
parent reply other threads:[~2009-03-15 14:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <tip-adf26f84a62b492e002d3b75af671f23ddd3be0a@git.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090315145453.GA5105@nowhere \
--to=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.