All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] [XFS] Fix double free of inode
Date: Sun, 15 Mar 2009 11:13:41 -0400	[thread overview]
Message-ID: <20090315151340.GA7145@infradead.org> (raw)
In-Reply-To: <1237116342-25701-3-git-send-email-david@fromorbit.com>

On Sun, Mar 15, 2009 at 10:25:42PM +1100, Dave Chinner wrote:
> If we fail to initialise the VFS inode in inode_init_always(),
> it will call ->delete_inode internally resulting in the inode being
> freed. Hence we need to delay the call to inode_init_always()
> until after the XFS inode is sufficient set up to handle a
> call to ->delete_inode, and then if that fails do not touch
> the inode again at all as it has been freed.

Looks good, but the changelog should mention the setting of the
I_NEW bit, too.


Reviewed-by: Christoph Hellwig <hch@lst.de>

I suspect this should go into 2.6.29-stable after some testing, too.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2009-03-15 15:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-15 11:25 [PATCH 0/2, RESEND] [XFS] a couple of fixes Dave Chinner
2009-03-15 11:25 ` [PATCH 1/2] [XFS] Validate log feature fields correctly Dave Chinner
2009-03-15 15:15   ` Christoph Hellwig
2009-03-16 10:49     ` Dave Chinner
2009-03-16 10:50       ` Christoph Hellwig
2009-03-15 11:25 ` [PATCH 2/2] [XFS] Fix double free of inode Dave Chinner
2009-03-15 15:13   ` Christoph Hellwig [this message]
2009-04-06 22:28 ` [PATCH 0/2, RESEND] [XFS] a couple of fixes Christoph Hellwig
2009-04-08  4:45   ` Felix Blyakher
2009-04-08 13:33     ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2009-03-15 10:52 [PATCH 0/2] " Dave Chinner
2009-03-15 10:52 ` [PATCH 2/2] [XFS] Fix double free of inode Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090315151340.GA7145@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.