From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LisMp-0005EE-Sg for mharc-grub-devel@gnu.org; Sun, 15 Mar 2009 11:35:11 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LisMm-0005Dw-Uw for grub-devel@gnu.org; Sun, 15 Mar 2009 11:35:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LisMi-0005Dc-Bz for grub-devel@gnu.org; Sun, 15 Mar 2009 11:35:08 -0400 Received: from [199.232.76.173] (port=48236 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LisMi-0005DZ-6W for grub-devel@gnu.org; Sun, 15 Mar 2009 11:35:04 -0400 Received: from aybabtu.com ([69.60.117.155]:36134) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LisMh-0008Fn-Nz for grub-devel@gnu.org; Sun, 15 Mar 2009 11:35:03 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LisDy-00040z-An for grub-devel@gnu.org; Sun, 15 Mar 2009 16:26:02 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LisMZ-0006PC-6A for grub-devel@gnu.org; Sun, 15 Mar 2009 16:34:55 +0100 Date: Sun, 15 Mar 2009 16:34:55 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090315153455.GA24554@thorin> References: <4992ABA6.7040200@gmail.com> <49BAEDAD.3030704@gmail.com> <20090314144844.GA13451@thorin> <49BBEEF7.9000107@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49BBEEF7.9000107@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [Patch] Move multiboot helpers out of the kernel X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Mar 2009 15:35:09 -0000 On Sat, Mar 14, 2009 at 06:52:55PM +0100, phcoder wrote: > Robert Millan wrote: >> On Sat, Mar 14, 2009 at 12:35:09AM +0100, phcoder wrote: >>> Index: conf/i386-ieee1275.rmk >>> =================================================================== >>> --- conf/i386-ieee1275.rmk (revision 2030) >>> +++ conf/i386-ieee1275.rmk (working copy) >>> @@ -126,10 +126,12 @@ >>> # For _multiboot.mod. >>> _multiboot_mod_SOURCES = loader/ieee1275/multiboot2.c \ >>> + loader/i386/multiboot_helper.S \ >> >> multiboot_helper.S is not being used on i386-ieee1275 AFAICT > > How can it be if multiboot.c is the same for pc and ieee1275? $ grep multiboot.c conf/*.rmk conf/i386-coreboot.rmk:_multiboot_mod_SOURCES = loader/i386/multiboot.c \ conf/i386-pc.rmk:_multiboot_mod_SOURCES = loader/i386/multiboot.c \ >> grub_dl_unload_all() just disappeared. Is this intentional? I >> tend to agree that grub_dl_unload_all() is a waste of time, but >> this should be discussed separately. > > It is intentional because multiboot_real_boot is now in a module so we > can't unload it Ok then, I'm fine with disabling the unload. What does everybody else think? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."