All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
	linville@tuxdriver.com, jirislaby@gmail.com, mcgrof@gmail.com,
	nbd@openwrt.org
Subject: Re: [PATCH 1/3] ath5k: Choose the right initvals for RF2425
Date: Sun, 15 Mar 2009 22:28:21 -0400	[thread overview]
Message-ID: <20090316022821.GA14792@hash.localnet> (raw)
In-Reply-To: <20090315201339.GA5246@makis>

On Sun, Mar 15, 2009 at 10:13:39PM +0200, Nick Kossifidis wrote:
>  * Fix a typo in initvals.c so that we use the RF2425 array for RF2425 and not RF2413
> 
>  Note: This also fixes incorect pd gain overlap since RF2425 has different pd gain overlap from RF2413
> 
>  Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>

Nice work, series:

Acked-by: Bob Copeland <me@bobcopeland.com>

If you do a follow-up cleanup patch, one quick thought I had is that
ee_pwr_cal_[abg] could be an array indexed by mode which might save a 
few switch statements - I didn't look at it that hard though.

-- 
Bob Copeland %% www.bobcopeland.com


  reply	other threads:[~2009-03-16  2:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-15 20:13 [PATCH 1/3] ath5k: Choose the right initvals for RF2425 Nick Kossifidis
2009-03-16  2:28 ` Bob Copeland [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-03-10 10:29 Nick Kossifidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090316022821.GA14792@hash.localnet \
    --to=me@bobcopeland.com \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.