All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] XFS: Inform the xfsaild of the push target before sleeping
Date: Mon, 16 Mar 2009 22:00:52 +1100	[thread overview]
Message-ID: <20090316110052.GL26138@disturbed> (raw)
In-Reply-To: <20090316103836.GA24744@infradead.org>

On Mon, Mar 16, 2009 at 06:38:36AM -0400, Christoph Hellwig wrote:
> This looks good to me.
> 
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> But looking at that area I must say I'm not happy with it in general.
> There are tons of useless roundtrips l_grant_lock because we drop
> it just before calling xlog_grant_push_ail which needs it for
> most of it's operation, and because we acquire it just before
> sv_wait just to drop it.
> 
> And the duplication between xlog_grant_log_space
> xlog_regrant_write_log_space is quite ugly, too.

I totally agree, but I don't feel like trying to rewrite this
code right now. Maybe some rainy day....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2009-03-16 11:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-15 11:40 [PATCH 0/2] Fix a couple of random hangs Dave Chinner
2009-03-15 11:40 ` [PATCH 1/2] XFS: Prevent unwritten extent conversion from blocking I/O completion Dave Chinner
2009-03-16  9:21   ` Christoph Hellwig
2009-03-16 10:37     ` Dave Chinner
2009-03-15 11:40 ` [PATCH 2/2] XFS: Inform the xfsaild of the push target before sleeping Dave Chinner
2009-03-16 10:38   ` Christoph Hellwig
2009-03-16 11:00     ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090316110052.GL26138@disturbed \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.