From: Mark Brown <broonie@sirena.org.uk>
To: Naresh Medisetty <naresh@ti.com>
Cc: davinci-linux-open-source@linux.davincidsp.com,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 6/9] ARM: DaVinci: ASoC: Adds McASP clock support for TI DM646X processor
Date: Mon, 16 Mar 2009 15:20:29 +0000 [thread overview]
Message-ID: <20090316152028.GF16539@sirena.org.uk> (raw)
In-Reply-To: <1237205125-30211-1-git-send-email-naresh@ti.com>
On Mon, Mar 16, 2009 at 08:05:25AM -0400, Naresh Medisetty wrote:
> + CLK("soc-audio.0", NULL, &mcasp0_clk),
> + CLK("soc-audio.1", NULL, &mcasp1_clk),
Assuming this is a shorthand for defining two platform devices for two
ASoC cards I'd suggest that you instead move towards registering clocks
for the DAIs and probing them as platform devices - take a look at how
the PXA AC97 driver now does this for an example. The soc-audio device
will hopefully get removed at some point and you can't guarantee that
the user won't want to put the two DAIs into a single sound card.
next prev parent reply other threads:[~2009-03-16 15:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 12:05 [PATCH 6/9] ARM: DaVinci: ASoC: Adds McASP clock support for TI DM646X processor Naresh Medisetty
2009-03-16 15:20 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-18 12:11 Medisetty, Naresh
2009-03-19 17:38 ` Kevin Hilman
2009-03-19 19:09 ` Mark Brown
2009-03-19 21:14 ` Kevin Hilman
2009-03-19 21:28 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090316152028.GF16539@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=naresh@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.