From: Gleb Natapov <gleb@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: avi@redhat.com, marcelo@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] do not free active mmu pages in free_mmu_pages()
Date: Mon, 16 Mar 2009 23:32:35 +0200 [thread overview]
Message-ID: <20090316213235.GA18827@redhat.com> (raw)
In-Reply-To: <20090316213322.GA5439@amt.cnet>
On Mon, Mar 16, 2009 at 06:33:22PM -0300, Marcelo Tosatti wrote:
> On Mon, Mar 16, 2009 at 11:20:10PM +0200, Gleb Natapov wrote:
> > > mmu_lock should be held there, and apparently it is not.
> > >
> > Yeah, my first solution was to add mmu_lock, but why function that gets
> > vcpu as an input should destroy data structure that is global for the VM.
>
> Point.
>
> > There is kvm_mmu_zap_all() that does same thing (well almost) and also does
> > proper locking. Shouldn't it be called during VM destruction instead?
>
> Yes, that would better (which happens implicitly with mmu notifiers
> ->release).
OK. I'll send new patch.
--
Gleb.
prev parent reply other threads:[~2009-03-16 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 10:07 [PATCH] do not free active mmu pages in free_mmu_pages() Gleb Natapov
2009-03-15 12:59 ` Avi Kivity
2009-03-16 20:15 ` Marcelo Tosatti
2009-03-16 20:34 ` Gleb Natapov
2009-03-16 21:01 ` Marcelo Tosatti
2009-03-16 21:20 ` Gleb Natapov
2009-03-16 21:33 ` Marcelo Tosatti
2009-03-16 21:32 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090316213235.GA18827@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=marcelo@redhat.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.