From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: acme@redhat.com, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] [SK_BUFF]: '< 0' and '>= 0' test on unsigned
Date: Tue, 17 Mar 2009 14:29:30 -0300 [thread overview]
Message-ID: <20090317172930.GI22651@ghostprotocols.net> (raw)
In-Reply-To: <49BFA8EA.4000702@gmail.com>
Em Tue, Mar 17, 2009 at 02:43:06PM +0100, Roel Kluin escreveu:
> Was this patch missed?
>
> struct sk_buff is located at vi include/linux/skbuff.h +357:
> maybe a different test is needed in x25_rx_call_request()?
> ------------------------------>8-------------8<---------------------------------
> skb->len is an unsigned int, so the test in x25_rx_call_request() always
> evaluates to true.
>
> len in x25_sendmsg() is unsigned as well. so -ERRORS returned by x25_output()
> are not noticed.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
I saw DaveM applying this one, lemme see...
http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commit;h=8db09f26f912f7c90c764806e804b558da520d4f
- Arnaldo
next prev parent reply other threads:[~2009-03-17 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 13:43 [PATCH] [SK_BUFF]: '< 0' and '>= 0' test on unsigned Roel Kluin
2009-03-17 17:29 ` Arnaldo Carvalho de Melo [this message]
2009-03-17 19:25 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-03-01 22:00 Roel Kluin
2009-03-13 23:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090317172930.GI22651@ghostprotocols.net \
--to=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.