From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: jengelh@medozas.de, stephen.hemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: iproute2: prints bogus hoplimit
Date: Wed, 18 Mar 2009 17:54:59 -0700 (PDT) [thread overview]
Message-ID: <20090318.175459.00928247.davem@davemloft.net> (raw)
In-Reply-To: <20090318162928.163a2408@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 18 Mar 2009 16:29:28 -0700
> The issue is that the hoplimit metric in ipv6 gets converted
> to -1 (if it is zero on the incoming route request)..
>
> int ip6_route_add(struct fib6_config *cfg)
> {
> ...
> if (dst_metric(&rt->u.dst, RTAX_HOPLIMIT) == 0)
> rt->u.dst.metrics[RTAX_HOPLIMIT-1] = -1;
>
>
> What should happen is when ip6 returns the route back
> on the dump request (rt6_fill_node), it should translate the -1 back to 0
> to keep it symmetrical and logical. The metrics are unsigned.
This is how "default" is represented.
If you look, ipv4 does the same thing.
next prev parent reply other threads:[~2009-03-19 0:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-24 10:27 iproute2: prints bogus hoplimit Jan Engelhardt
2009-03-18 22:12 ` Stephen Hemminger
2009-03-18 22:35 ` Jan Engelhardt
2009-03-18 23:29 ` Stephen Hemminger
2009-03-19 0:54 ` David Miller [this message]
2009-03-19 0:51 ` David Miller
2009-03-19 1:01 ` Stephen Hemminger
2009-03-19 1:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090318.175459.00928247.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jengelh@medozas.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.