From: Chandra Seetharaman <sekharan@us.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: Chandra Seetharaman <sekharan@us.ibm.com>,
pjones@redhat.com, michaelc@cs.wisc.edu,
James.Bottomley@HansenPartnership.com
Subject: [PATCH 2/3] scsi_dh: Change scsi device handler modules to utilize modalias
Date: Tue, 17 Mar 2009 18:36:27 -0700 [thread overview]
Message-ID: <20090318013627.26548.27704.sendpatchset@chandra-ubuntu> (raw)
In-Reply-To: <20090318013615.26548.36303.sendpatchset@chandra-ubuntu>
From: Peter Jones <pjones@redhat.com>
This patch changes the scsi_dh files to make use of the modalias feature.
Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
---
drivers/scsi/device_handler/scsi_dh.c | 5 +++-
drivers/scsi/device_handler/scsi_dh_alua.c | 23 ++++++++-------
drivers/scsi/device_handler/scsi_dh_emc.c | 11 ++++---
drivers/scsi/device_handler/scsi_dh_hp_sw.c | 13 +++++----
drivers/scsi/device_handler/scsi_dh_rdac.c | 42 +++++++++++++++-------------
5 files changed, 51 insertions(+), 43 deletions(-)
Index: linux-2.6.28/drivers/scsi/device_handler/scsi_dh.c
===================================================================
--- linux-2.6.28.orig/drivers/scsi/device_handler/scsi_dh.c
+++ linux-2.6.28/drivers/scsi/device_handler/scsi_dh.c
@@ -75,7 +75,10 @@ static int scsi_dh_handler_lookup(struct
{
int i, found = 0;
- for(i = 0; scsi_dh->devlist[i].vendor; i++) {
+ for(i = 0; scsi_dh->devlist[i].vendor[0]; i++) {
+ if ((scsi_dh->devlist[i].type != TYPE_ANY) &&
+ (scsi_dh->devlist[i].type != sdev->type))
+ continue;
if (!strncmp(sdev->vendor, scsi_dh->devlist[i].vendor,
strlen(scsi_dh->devlist[i].vendor)) &&
!strncmp(sdev->model, scsi_dh->devlist[i].model,
Index: linux-2.6.28/drivers/scsi/device_handler/scsi_dh_alua.c
===================================================================
--- linux-2.6.28.orig/drivers/scsi/device_handler/scsi_dh_alua.c
+++ linux-2.6.28/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -681,18 +681,19 @@ static int alua_prep_fn(struct scsi_devi
}
-static const struct scsi_dh_devlist alua_dev_list[] = {
- {"HP", "MSA VOLUME" },
- {"HP", "HSV101" },
- {"HP", "HSV111" },
- {"HP", "HSV200" },
- {"HP", "HSV210" },
- {"HP", "HSV300" },
- {"IBM", "2107900" },
- {"IBM", "2145" },
- {"Pillar", "Axiom" },
- {NULL, NULL}
+static const struct scsi_dh_device_id alua_dev_list[] = {
+ {TYPE_ANY, "HP", "MSA VOLUME" },
+ {TYPE_ANY, "HP", "HSV101" },
+ {TYPE_ANY, "HP", "HSV111" },
+ {TYPE_ANY, "HP", "HSV200" },
+ {TYPE_ANY, "HP", "HSV210" },
+ {TYPE_ANY, "HP", "HSV300" },
+ {TYPE_ANY, "IBM", "2107900" },
+ {TYPE_ANY, "IBM", "2145" },
+ {TYPE_ANY, "Pillar", "Axiom" },
+ {0, "", ""},
};
+MODULE_DEVICE_TABLE(scsi_dh, alua_dev_list);
static int alua_bus_attach(struct scsi_device *sdev);
static void alua_bus_detach(struct scsi_device *sdev);
Index: linux-2.6.28/drivers/scsi/device_handler/scsi_dh_emc.c
===================================================================
--- linux-2.6.28.orig/drivers/scsi/device_handler/scsi_dh_emc.c
+++ linux-2.6.28/drivers/scsi/device_handler/scsi_dh_emc.c
@@ -562,12 +562,13 @@ done:
return result;
}
-static const struct scsi_dh_devlist clariion_dev_list[] = {
- {"DGC", "RAID"},
- {"DGC", "DISK"},
- {"DGC", "VRAID"},
- {NULL, NULL},
+static const struct scsi_dh_device_id clariion_dev_list[] = {
+ {TYPE_ANY, "DGC", "RAID"},
+ {TYPE_ANY, "DGC", "DISK"},
+ {TYPE_ANY, "DGC", "VRAID"},
+ {0, "", ""},
};
+MODULE_DEVICE_TABLE(scsi_dh, clariion_dev_list);
static int clariion_bus_attach(struct scsi_device *sdev);
static void clariion_bus_detach(struct scsi_device *sdev);
Index: linux-2.6.28/drivers/scsi/device_handler/scsi_dh_hp_sw.c
===================================================================
--- linux-2.6.28.orig/drivers/scsi/device_handler/scsi_dh_hp_sw.c
+++ linux-2.6.28/drivers/scsi/device_handler/scsi_dh_hp_sw.c
@@ -286,13 +286,14 @@ static int hp_sw_activate(struct scsi_de
return ret;
}
-static const struct scsi_dh_devlist hp_sw_dh_data_list[] = {
- {"COMPAQ", "MSA1000 VOLUME"},
- {"COMPAQ", "HSV110"},
- {"HP", "HSV100"},
- {"DEC", "HSG80"},
- {NULL, NULL},
+static const struct scsi_dh_device_id hp_sw_dh_data_list[] = {
+ {TYPE_ANY, "COMPAQ", "MSA1000 VOLUME"},
+ {TYPE_ANY, "COMPAQ", "HSV110"},
+ {TYPE_ANY, "HP", "HSV100"},
+ {TYPE_ANY, "DEC", "HSG80"},
+ {0, "", ""},
};
+MODULE_DEVICE_TABLE(scsi_dh, hp_sw_dh_data_list);
static int hp_sw_bus_attach(struct scsi_device *sdev);
static void hp_sw_bus_detach(struct scsi_device *sdev);
Index: linux-2.6.28/drivers/scsi/device_handler/scsi_dh_rdac.c
===================================================================
--- linux-2.6.28.orig/drivers/scsi/device_handler/scsi_dh_rdac.c
+++ linux-2.6.28/drivers/scsi/device_handler/scsi_dh_rdac.c
@@ -585,28 +585,30 @@ static int rdac_check_sense(struct scsi_
return SCSI_RETURN_NOT_HANDLED;
}
-static const struct scsi_dh_devlist rdac_dev_list[] = {
- {"IBM", "1722"},
- {"IBM", "1724"},
- {"IBM", "1726"},
- {"IBM", "1742"},
- {"IBM", "1814"},
- {"IBM", "1815"},
- {"IBM", "1818"},
- {"IBM", "3526"},
- {"SGI", "TP9400"},
- {"SGI", "TP9500"},
- {"SGI", "IS"},
- {"STK", "OPENstorage D280"},
- {"SUN", "CSM200_R"},
- {"SUN", "LCSM100_F"},
- {"DELL", "MD3000"},
- {"DELL", "MD3000i"},
- {"LSI", "INF-01-00"},
- {"ENGENIO", "INF-01-00"},
- {NULL, NULL},
+static const struct scsi_dh_device_id rdac_dev_list[] = {
+ {TYPE_ANY, "IBM", "1722"},
+ {TYPE_ANY, "IBM", "1724"},
+ {TYPE_ANY, "IBM", "1726"},
+ {TYPE_ANY, "IBM", "1742"},
+ {TYPE_ANY, "IBM", "1814"},
+ {TYPE_ANY, "IBM", "1815"},
+ {TYPE_ANY, "IBM", "1818"},
+ {TYPE_ANY, "IBM", "3526"},
+ {TYPE_ANY, "SGI", "TP9400"},
+ {TYPE_ANY, "SGI", "TP9500"},
+ {TYPE_ANY, "SGI", "IS"},
+ {TYPE_ANY, "STK", "OPENstorage D280"},
+ {TYPE_ANY, "SUN", "CSM200_R"},
+ {TYPE_ANY, "SUN", "LCSM100_F"},
+ {TYPE_ANY, "DELL", "MD3000"},
+ {TYPE_ANY, "DELL", "MD3000i"},
+ {TYPE_ANY, "LSI", "INF-01-00"},
+ {TYPE_ANY, "ENGENIO", "INF-01-00"},
+ {0, "", ""},
};
+MODULE_DEVICE_TABLE(scsi_dh, rdac_dev_list);
+
static int rdac_bus_attach(struct scsi_device *sdev);
static void rdac_bus_detach(struct scsi_device *sdev);
next prev parent reply other threads:[~2009-03-18 1:33 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 1:36 [PATCH 0/3] scsi_dh: Make scsi device handler modules automatically inserted Chandra Seetharaman
2009-03-18 1:36 ` [PATCH 1/3] scsi_dh: Add modalias support for SCSI targets Chandra Seetharaman
2009-03-18 13:44 ` Konrad Rzeszutek
2009-03-18 14:02 ` James Bottomley
2009-03-18 14:36 ` Konrad Rzeszutek
2009-03-18 18:30 ` Kay Sievers
2009-03-18 19:18 ` Chandra Seetharaman
2009-03-19 18:54 ` Chandra Seetharaman
2009-03-20 18:24 ` Peter Jones
2009-03-23 22:13 ` Chandra Seetharaman
2009-04-03 22:43 ` Chandra Seetharaman
2009-04-07 20:59 ` James Bottomley
2009-04-07 23:41 ` Chandra Seetharaman
2009-04-08 15:08 ` Peter Jones
2009-04-15 21:52 ` Chandra Seetharaman
2009-04-16 15:18 ` Hannes Reinecke
2009-04-07 23:22 ` Hannes Reinecke
2009-04-07 23:50 ` Chandra Seetharaman
2009-04-08 5:15 ` Kay Sievers
2009-04-08 19:13 ` Chandra Seetharaman
2009-03-18 18:47 ` James Bottomley
2009-03-18 19:12 ` Chandra Seetharaman
2009-03-18 20:09 ` James Bottomley
2009-03-18 20:24 ` Kay Sievers
2009-03-18 20:26 ` James Bottomley
2009-03-18 20:59 ` Chandra Seetharaman
2009-03-20 17:41 ` Peter Jones
2009-03-18 1:36 ` Chandra Seetharaman [this message]
2009-03-18 13:46 ` [PATCH 2/3] scsi_dh: Change scsi device handler modules to utilize modalias Konrad Rzeszutek
2009-03-18 15:43 ` Stefan Richter
2009-03-18 17:25 ` Chandra Seetharaman
2009-03-18 17:50 ` Stefan Richter
2009-03-18 18:18 ` Kay Sievers
2009-03-18 19:44 ` Stefan Richter
2009-03-18 18:50 ` Chandra Seetharaman
2009-03-18 19:46 ` Stefan Richter
2009-03-18 1:36 ` [PATCH 3/3] scsi_dh: Workaround a race condition in module insertion Chandra Seetharaman
2009-03-18 11:31 ` [PATCH 0/3] scsi_dh: Make scsi device handler modules automatically inserted Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2009-04-27 18:06 Chandra Seetharaman
2009-04-27 18:06 ` [PATCH 2/3] scsi_dh: Change scsi device handler modules to utilize modalias Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090318013627.26548.27704.sendpatchset@chandra-ubuntu \
--to=sekharan@us.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.