From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: Vlad Yasevich <vladislav.yasevich@hp.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] fix sctp breakage
Date: Wed, 18 Mar 2009 03:25:08 +0000 [thread overview]
Message-ID: <20090318032508.GY28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090318031405.GX28946@ZenIV.linux.org.uk>
On Wed, Mar 18, 2009 at 03:14:05AM +0000, Al Viro wrote:
> broken by commit 5e739d1752aca4e8f3e794d431503bfca3162df4; AFAICS should
> be -stable fodder as well...
PS: existing code *DOES* produce correct value; sizeof in question is
4, and htons(4) + htons(2) happens to be equal to htons(6) (no carryover).
So before anyone starts moaning about coverups again, no, this is not
a roothole fix we are trying to get past grsec tossers.
It needs fixing, though, accidentally correct value or not.
next prev parent reply other threads:[~2009-03-18 3:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 3:14 [PATCH] fix sctp breakage Al Viro
2009-03-18 3:25 ` Al Viro [this message]
2009-03-18 12:28 ` Vlad Yasevich
2009-03-19 2:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090318032508.GY28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.