From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
balbir@linux.vnet.ibm.com, Li Zefan <lizf@cn.fujitsu.com>,
linux-kernel@vger.kernel.org,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Paul Menage <menage@google.com>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH -tip] cpuacct: Make cpuacct hierarchy walk in cpuacct_charge() safe when rcupreempt is used.
Date: Wed, 18 Mar 2009 13:35:39 +0530 [thread overview]
Message-ID: <20090318080539.GD3960@in.ibm.com> (raw)
In-Reply-To: <20090318160827.fa53cb9b.kamezawa.hiroyu@jp.fujitsu.com>
On Wed, Mar 18, 2009 at 04:08:27PM +0900, KAMEZAWA Hiroyuki wrote:
> On Wed, 18 Mar 2009 10:18:01 +0530
> Bharata B Rao <bharata@linux.vnet.ibm.com> wrote:
> > Looks ok to me, but will wait for experts' comments.
> >
> > However, I did a quick measurement of read times with percpu_counter_read()
> > (no readside lock) and percpu_counter_sum() (readside lock) and I don't
> > see a major slowdown with percpu_counter_sum().
> >
> > Time taken for 100 reads of cpuacct.stat with 1s delay b/n every read.
> > percpu_counter_read() - 9845 us
> > percpu_counter_sum() - 9974 us
> >
> Then, almost 1 us overhead per read().....Hmm, seems big (as counter).
Well some cost for correct and accurate counter :)
BTW, I did a few more iterations and I don't see consistent numbers.
The results from 7 runs look like this:
percpu_counter_read() - 11325, 11549, 5939, 9999, 7129, 7758, 11385 us
percpu_counter_sum() - 8655, 9201, 8705, 11766, 10619, 9186, 8890 us
Regards,
Bharata.
next prev parent reply other threads:[~2009-03-18 8:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 6:17 [PATCH -tip] cpuacct: Make cpuacct hierarchy walk in cpuacct_charge() safe when rcupreempt is used Bharata B Rao
2009-03-17 6:28 ` Li Zefan
2009-03-17 7:36 ` Bharata B Rao
2009-03-17 13:12 ` Balbir Singh
2009-03-17 13:26 ` Peter Zijlstra
2009-03-17 13:59 ` Balbir Singh
2009-03-17 14:04 ` Peter Zijlstra
2009-03-18 3:25 ` Bharata B Rao
2009-03-18 3:54 ` KAMEZAWA Hiroyuki
2009-03-18 4:48 ` Bharata B Rao
2009-03-18 7:08 ` KAMEZAWA Hiroyuki
2009-03-18 8:05 ` Bharata B Rao [this message]
2009-03-17 23:59 ` KAMEZAWA Hiroyuki
2009-03-18 3:18 ` Bharata B Rao
2009-03-18 9:36 ` Balbir Singh
2009-03-19 9:20 ` Peter Zijlstra
2009-03-19 9:43 ` Bharata B Rao
2009-03-17 12:40 ` Balbir Singh
2009-03-18 1:40 ` Li Zefan
2009-03-18 2:59 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090318080539.GD3960@in.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=balbir@linux.vnet.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.