From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LjslI-0002Ot-WB for mharc-grub-devel@gnu.org; Wed, 18 Mar 2009 06:12:37 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LjslH-0002Og-DW for grub-devel@gnu.org; Wed, 18 Mar 2009 06:12:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LjslC-0002OE-Oi for grub-devel@gnu.org; Wed, 18 Mar 2009 06:12:35 -0400 Received: from [199.232.76.173] (port=60426 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LjslC-0002O4-L0 for grub-devel@gnu.org; Wed, 18 Mar 2009 06:12:30 -0400 Received: from aybabtu.com ([69.60.117.155]:40064) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LjslC-0003s4-Bd for grub-devel@gnu.org; Wed, 18 Mar 2009 06:12:30 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LjscH-0008MQ-JO for grub-devel@gnu.org; Wed, 18 Mar 2009 11:03:18 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Ljsl9-0005Er-Cv for grub-devel@gnu.org; Wed, 18 Mar 2009 11:12:27 +0100 Date: Wed, 18 Mar 2009 11:12:27 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090318101227.GB20072@thorin> References: <49B82B65.3080506@gmail.com> <20090313191442.GC17068@thorin> <49BAC506.2030006@gmail.com> <20090313.134505.185970759.davem@davemloft.net> <49BAC797.9010200@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49BAC797.9010200@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: ELF bugfixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2009 10:12:35 -0000 On Fri, Mar 13, 2009 at 09:52:39PM +0100, phcoder wrote: > - grub_multiboot_payload_entry_offset = ehdr->e_entry - phdr(lowest_segment)->p_vaddr; > + for (i = 0; i < ehdr->e_phnum; i++) > + if (phdr(i)->p_vaddr <= ehdr->e_entry > + && phdr(i)->p_vaddr + phdr(i)->p_memsz > ehdr->e_entry) > + grub_multiboot_payload_entry_offset = (ehdr->e_entry - phdr(i)->p_vaddr) > + + (phdr(i)->p_paddr - phdr(lowest_segment)->p_paddr); You need to handle the case in which grub_multiboot_payload_entry_offset is left uninitialized (it needs to be initialized each time the multiboot command is run, not just when the module is loaded). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."